5.0: Granular Routing policy. Service chain ecmp case has intf_route_type incorrectly assigned for interface, interface static and serivice interface types

[Shashikiran H]

Version: 5.0
Picked up the latest build.

Topo:
10.204.217.7 cfgm control ui openstack
10.204.216.68 cfgm control
10.204.216.72 cfgm control
10.204.217.16 vrouter
10.204.217.17 vrouter

left-vn --- si1(ecmp, in-network) --- si2(ecmp, nat) --- right-vn

I see that intf_route_type for some interface, interface static and service interface is completely wrong. I see service -interface type routes being selected for "interface" protocol, interface selected for "service-interface" protocol etc. This is apart from seeing bugs, 1753628 and 1753631 as well.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40654
Submitter: Nipa Kumar (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40654
Committed: http://github.com/Juniper/contrail-controller/commit/db53bbe3d674309384d92f37f8cab34e3be34aff
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit db53bbe3d674309384d92f37f8cab34e3be34aff
Author: Nipa Kumar <email address hidden>
Date: Wed Mar 14 14:29:58 2018 -0700

Set intf_route_type correctly

1)Set default intf_route_type in another VmInterface constructor that was missed.
2)Route-reflect should not update intf_route_type to default (effects introspect only)

Change-Id: I9f2fe88cb131e3d039a9aaee373b9f60b8d08789
Closes-Bug: #1754594