ConfigDebug is always translated as true by ansible

[Dan Prince]

We have enable_debug wired into our Ansible tasks like this:

   when: enable_debug|default(false)

Because the statement is not typecast into a boolean it is handled as a string and since it is always set to "true" or "false" by Heat (because Heat passes it as a bool) the value is always enabled.

----

I think this means that ConfigDebug is effectively always enabled at this point.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/551020

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/551020
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d87325990cac08f13991fee38bb993296b594b34
Submitter: Zuul
Branch: master

commit d87325990cac08f13991fee38bb993296b594b34
Author: Dan Prince <email address hidden>
Date: Thu Mar 8 16:51:08 2018 -0500

    Treat enable_debug in Ansible as a bool

    Without the extra bool this when block gets evaluated as a string.
    Given that it is always present this means enable_debug has been
    enabled regardless of the end user setting.

    Change-Id: I9f53f3bca4a6862966e558ea20fe001eabda7bcf
    Closes-bug: #1754481

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/582423

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/582423
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=47cf9f453a3915e6f098d5b893c9e74dfdca8077
Submitter: Zuul
Branch: stable/queens

commit 47cf9f453a3915e6f098d5b893c9e74dfdca8077
Author: Dan Prince <email address hidden>
Date: Thu Mar 8 16:51:08 2018 -0500

    Treat enable_debug in Ansible as a bool

    Without the extra bool this when block gets evaluated as a string.
    Given that it is always present this means enable_debug has been
    enabled regardless of the end user setting.

    Change-Id: I9f53f3bca4a6862966e558ea20fe001eabda7bcf
    Closes-bug: #1754481
    (cherry picked from commit d87325990cac08f13991fee38bb993296b594b34)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.5 release.