Modal footer not showing in Firefox

Bug #1754098 reported by Liz Blanchard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jiri Tomasek

Bug Description

Description
===========
The modal footer on a long form is not showing in the view port on Firefox. It's impossible to confirm any modal action without being able to see the buttons.

Steps to reproduce
==================
1) Login to UI on Firefox browser.
2) Select Plan.
3) Click "Edit Configuration" button on Step 2 of workflow.
4) Navigate to section with long form to view buttons fall off of the page.
5) Attempt to scroll to bottom without success in seeing buttons.

Expected result
===============
Modal footer is at the bottom of the viewport, always shown to the user and the form scrolls above this.

Actual result
=============
Modal footer is off of the page and not accessible to the user no matter how much scrolling is done.

Environment
===========
1. Dev environment running master based on default TripleO QuickStart.
2. CentOS 7
3. Firefox 52

Revision history for this message
Liz Blanchard (lblanchard) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/550536

Changed in tripleo:
assignee: nobody → Jiri Tomasek (jtomasek)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/550536
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=2077c458191679c6d23c17bc80562e6fd2aa6a74
Submitter: Zuul
Branch: master

commit 2077c458191679c6d23c17bc80562e6fd2aa6a74
Author: Jiri Tomasek <email address hidden>
Date: Wed Mar 7 17:50:53 2018 +0100

    Fix ModalPanel in Firefox

    As explained here: https://stackoverflow.com/questions/28636832/firefox-overflow-y-not-working-with-nested-flexbox
    Flex items need to have min -height/width set to 0 to allow
    children overflow property to work

    Closes-Bug: #1754098
    Change-Id: Ib1c4765cbdf12e66f98a336e6f3cc85e721db1f0

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/551916

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (stable/queens)

Reviewed: https://review.openstack.org/551916
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=e3909280ba1d34b9b9e52a438227b054b2421a8a
Submitter: Zuul
Branch: stable/queens

commit e3909280ba1d34b9b9e52a438227b054b2421a8a
Author: Jiri Tomasek <email address hidden>
Date: Wed Mar 7 17:50:53 2018 +0100

    Fix ModalPanel in Firefox

    As explained here: https://stackoverflow.com/questions/28636832/firefox-overflow-y-not-working-with-nested-flexbox
    Flex items need to have min -height/width set to 0 to allow
    children overflow property to work

    Closes-Bug: #1754098
    Change-Id: Ib1c4765cbdf12e66f98a336e6f3cc85e721db1f0
    (cherry picked from commit 2077c458191679c6d23c17bc80562e6fd2aa6a74)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 8.3.1

This issue was fixed in the openstack/tripleo-ui 8.3.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 9.0.0

This issue was fixed in the openstack/tripleo-ui 9.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.