openstack undercloud install --use-heat fails when no container image params provided

[James Slagle]

[centos@undercloud-containers ~]$ cat undercloud.conf
[DEFAULT]
net_config_override = net-config-override.json
[centos@undercloud-containers ~]$ openstack undercloud install --use-heat

Fails with:

2018-03-07 15:13:15Z [undercloud.UndercloudServiceChain]: CREATE_FAILED StackValidationFailed: resources.UndercloudServiceChain.resources.ServiceChain: Property error: ServiceChain.resources[24].properties: Property D[0/1939]
tronConfigImage not assigned
2018-03-07 15:13:15Z [undercloud]: CREATE_FAILED Resource CREATE failed: StackValidationFailed: resources.UndercloudServiceChain.resources.ServiceChain: Property error: ServiceChain.resources[24].properties: Property DockerNe
utronConfigImage not assigned
curl -g -i -X GET -H 'X-Region-Name: regionOne' -H 'X-Auth-Token: {SHA1}c053ecf9ed41df0311b9df13cc6c3b6078d2d3c2' -H 'Content-Type: application/json' -H 'Accept: application/json' -H 'User-Agent: python-heatclient' http://127.
0.0.1:8006/v1/admin/stacks/undercloud/72a0431d-8bd8-4576-8da7-b327f7f8b702/events?marker=3e1845d4-9da5-4a2b-93b4-7452df90b2ca&nested_depth=6&sort_dir=asc
Starting new HTTP connection (1): 127.0.0.1
http://127.0.0.1:8006 "GET /v1/admin/stacks/undercloud/72a0431d-8bd8-4576-8da7-b327f7f8b702/events?marker=3e1845d4-9da5-4a2b-93b4-7452df90b2ca&nested_depth=6&sort_dir=asc HTTP/1.1" 200 14

<snip>

Exception: Stack create failed;
 Stack undercloud/72a0431d-8bd8-4576-8da7-b327f7f8b702 CREATE_FAILED

['Traceback (most recent call last):\n', ' File "/usr/lib/python2.7/site-packages/tripleoclient/v1/undercloud_deploy.py", line 574, in take_action\n raise Exception("Stack create failed; %s" % msg)\n', 'Exception: Stack cr
eate failed; \n Stack undercloud/72a0431d-8bd8-4576-8da7-b327f7f8b702 CREATE_FAILED \n\n']
ERROR: Heat log files: /var/tmp/undercloud/undercloud_deploy-KAgR6R
clean_up DeployUndercloud:
END return value: 1
Command '['sudo', 'openstack', 'undercloud', 'deploy', '--local-ip=192.168.24.1', '--templates=/usr/share/openstack-tripleo-heat-templates/', '--heat-native', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/ser
vices-docker/ironic.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/services-docker/ironic-inspector.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/services-docker/mistral.yaml',
'-e', '/usr/share/openstack-tripleo-heat-templates/environments/services-docker/zaqar.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/docker.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/envi
ronments/config-download-environment.yaml', '-e', '/usr/share/openstack-tripleo-heat-templates/environments/undercloud.yaml', '-e', '/tmp/undercloud_parameters.yaml', '--output-dir=/home/centos', '--debug']' returned non-zero
exit status 1

[Dan Prince (dan-prince)]

I think the right workflow would be having the user run 'openstack overcloud container image prepare' first to output an env file that can get plugged into undercloud.conf. This would match how containers configuration works for the Overcloud which is a good place to start.

For downstream we can provide a default, or perhaps even have this workflow action automated such that it "discovers" the latest containers and generates the file for you.

[Alex Schultz (alex-schultz)]

There is a new parameter in undercloud.conf called containers_images_file which we should check if it's set or fail. Until we have an automated container pulling method, we should validate this setting before we actually deploy.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/550552

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/550552
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f0bad0df6722d13463e039e0c3b66b9f925e81b0
Submitter: Zuul
Branch: master

commit f0bad0df6722d13463e039e0c3b66b9f925e81b0
Author: Alex Schultz <email address hidden>
Date: Wed Mar 7 11:02:11 2018 -0700

    Make container_images_file required

    When doing a containerized undercloud deployment, it is required to
    pass in a file containing the containers to use. Previously there was
    a default value meaning if you didn't pass in the file it would start
    but fail during the deployment because the containers were not defined.
    This parameter is required until we come up with a solution to
    automatically generate this file during the deployment.

    Change-Id: I2a5694f3dd623672c2841ccfdcf1f6325509d806
    Partial-Bug: #1754067

[Bogdan Dobrelya (bogdando)]

Solved in https://review.openstack.org/#/c/545161/ https://review.openstack.org/#/c/555051/ https://review.openstack.org/#/c/546024