Hold Status Translation Missing for Picked Up Holds (9)

[Ryan Eby]

* Evergreen 3.0.2
* PostgreSQL 9.6.6-1.pgdg16.04+1
* Ubuntu 16.04.03
* Chrome 64.0.3282.186

This is an edge case and shouldn't be encountered in day to day operations.

It can occur in two cases:

* There is a lag in the hold shelf list rendering that ends up including items that were picked up while it was loading the rows (eg/staff/circ/holds/shelf)
* A staff member accesses a detailed hold view page after the hold was already picked up (eg/staff/circ/holds/shelf/XXXXXXX) through an emailed link or some other source.

In both cases, the Status field will just have the number 9. This appears to be the status code for completed holds (ones the patron has picked up). I'm not completely sure where this is coming from as I mostly saw status 8 in the database. Other sites confirmed the 9 status by going to the detailed view of completed holds.

In our case I just added a Picked Up by Patron status in the hold_strings.tt2 for status 9 so staff wouldn't be confused while we worked on some performance issues.

This is low priority but it seems like there probably should be a translation included for status 9.

File affected: Open-ILS / src / templates / staff / circ / share / hold_strings.tt2

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/templates/staff/circ/share/hold_strings.tt2;hb=HEAD

[Josh Stompro (u-launchpad-stompro-org)]

Still an issue in 3.11.

Fix seems straight forward for this.

Hold Status logic can be seen at
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm;hb=c473623fce2e1b43455bc99c8c4700c26755ab3c#l1563

1574 if ($hold->fulfillment_time) {
1575 return 9;
1576 }

s.HOLD_STATUS_9 = "[% l('Fulfilled') %]";

Looks like that is what the Angular interfaces are using.
https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/app/staff/share/holds/detail.component.html;hb=221725a66032d2087481798db6c77b7bd7b7eccc#l44

Here is working branch to add that to the AngularJS interfaces.
user/stompro/lp1753795_angularjs_hold_status_fulfilled_string

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1753795_angularjs_hold_status_fulfilled_string