i18n javascript on login page requires login (again)

[John Dilley]

https://bugs.launchpad.net/horizon/+bug/1708671 was marked as "Invalid"/Fixed, with the fix being this revert: https://git.openstack.org/cgit/openstack/horizon/commit/?h=stable/queens&id=c16ceb149c855411aec66d713eddc8d6c62f9b30

However, it seems to have been reintroduced in https://git.openstack.org/cgit/openstack/horizon/commit/?h=stable/queens&id=077163a03c9aea08efd56251e49d69eb1cc4d093 - after reverting this patch in my local installation it all seems happy again.

This affects the queens release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/553969

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/553970

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/552789
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f494c6f2d475bfc936b78fda7ce11ed4d46c7224
Submitter: Zuul
Branch: master

commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224
Author: Shu Muto <email address hidden>
Date: Wed Mar 14 11:43:12 2018 +0900

    Fix Angular errors in openstack_auth

    Angular errors on login page are caused by loading ngdetails view.
    Although registration of URL for ngdetails is executed on top level
    of Horizon, ngdetails view is not needed to be loaded in login page,
    i.e. openstack_auth side.
    To fix this issue, this patch moves registration of URL for ngdetails
    into openstack_dashboard side.

    Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
    Closes-Bug: #1754133
    Closes-Bug: #1753557

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553969
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=676b1de40d9f3e4e01fd297ca0ac95a7badaeb7e
Submitter: Zuul
Branch: stable/queens

commit 676b1de40d9f3e4e01fd297ca0ac95a7badaeb7e
Author: Shu Muto <email address hidden>
Date: Wed Mar 14 11:43:12 2018 +0900

    Fix Angular errors in openstack_auth

    Angular errors on login page are caused by loading ngdetails view.
    Although registration of URL for ngdetails is executed on top level
    of Horizon, ngdetails view is not needed to be loaded in login page,
    i.e. openstack_auth side.
    To fix this issue, this patch moves registration of URL for ngdetails
    into openstack_dashboard side.

    Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
    Closes-Bug: #1754133
    Closes-Bug: #1753557
    (cherry picked from commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/553970
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6f6f46dc6d2f38719b114a80edabe2eb01b1ab06
Submitter: Zuul
Branch: stable/pike

commit 6f6f46dc6d2f38719b114a80edabe2eb01b1ab06
Author: Shu Muto <email address hidden>
Date: Wed Mar 14 11:43:12 2018 +0900

    Fix Angular errors in openstack_auth

    Angular errors on login page are caused by loading ngdetails view.
    Although registration of URL for ngdetails is executed on top level
    of Horizon, ngdetails view is not needed to be loaded in login page,
    i.e. openstack_auth side.
    To fix this issue, this patch moves registration of URL for ngdetails
    into openstack_dashboard side.

    Conflicts:
     openstack_dashboard/test/urls.py
     openstack_dashboard/urls.py

    The above conflicts are caused by bp/django2-support which landed in Rocky,
    particully by https://review.openstack.org/#/c/527323/12.

    Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
    Closes-Bug: #1754133
    Closes-Bug: #1753557
    (cherry picked from commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 13.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 12.0.3 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/629374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/629374
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c920dc9d42bea38a5ea9d1964161f14a80fe7ae7
Submitter: Zuul
Branch: stable/ocata

commit c920dc9d42bea38a5ea9d1964161f14a80fe7ae7
Author: Shu Muto <email address hidden>
Date: Wed Mar 14 11:43:12 2018 +0900

    Fix Angular errors in openstack_auth

    Angular errors on login page are caused by loading ngdetails view.
    Although registration of URL for ngdetails is executed on top level
    of Horizon, ngdetails view is not needed to be loaded in login page,
    i.e. openstack_auth side.
    To fix this issue, this patch moves registration of URL for ngdetails
    into openstack_dashboard side.

    Conflicts:
     openstack_dashboard/test/urls.py
     openstack_dashboard/urls.py

    The above conflicts are caused by bp/django2-support which landed in Rocky,
    particully by https://review.openstack.org/#/c/527323/12.

    Another problem:

    ngdetails url doesn't have project prefix after Ocata release, pls see:
    https://github.com/openstack/horizon/blob/stable/ocata/ \
        openstack_dashboard/static/app/core/images/images.service.js#L59
    https://github.com/openstack/horizon/blob/stable/pike/ \
        openstack_dashboard/static/app/core/images/images.service.js#L69

    So the following simple changes need to be made in urls.py
    in addition to the primitive backport patches.

    -ngdetails_url = url(r'^ngdetails/',
    +ngdetails_url = url(r'^project/ngdetails/',

    Change-Id: Ib039417b4e666c2341f17ac05fd7723bc758816c
    Closes-Bug: #1754133
    Closes-Bug: #1753557
    (cherry picked from commit f494c6f2d475bfc936b78fda7ce11ed4d46c7224)
    (cherry picked from commit 6f6f46dc6d2f38719b114a80edabe2eb01b1ab06)
    Signed-off-by: Zhang Hua <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon ocata-eol release.