horizon test helper prevents mox free horizon plugin

Bug #1753555 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Akihiro Motoki

Bug Description

Currently horizon test helpers (horizon/test/helpers.py and openstack_dashboard/test/helpers.py) always imports mox3.
These test helpers are consumed by horizon plugins.
Even when horizon plugins are mox free, these test helpers requires mox3 and plugins cannot drop mox3 from test-requirements.txt. mox should be optional in horizon test helpers.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/549842

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/549842
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb9ef26a7b26f42c350b7a15e988ce58ce1da943
Submitter: Zuul
Branch: master

commit fb9ef26a7b26f42c350b7a15e988ce58ce1da943
Author: Akihiro Motoki <email address hidden>
Date: Tue Mar 6 03:44:31 2018 +0900

    Allow mox-free horizon plugins to consume horizon test helper

    horizon test helpers now depend on mox3.
    This prevents horizon plugins from consuming the test helpers
    even if a plugin itself is mox free.
    This commit makes mox import optional.

    Change-Id: I631518d8f4cd9641920f68cd1e405298ddb7965a
    Closes-Bug: #1753555

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 14.0.0.0b1

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.