osd charm needs to validate imput of the osd-reformat option
Bug #1752944 reported by
Chris MacNaughton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ceph OSD Charm |
Fix Released
|
Low
|
James Page | ||
Bug Description
As this option is evaluated for truthiness, 'yes' or 'no' are both value, truthy values; so we will reformat osds with this is set to 'no'
Revision history for this message
| James Page (james-page) wrote | #1 |
| Changed in charm-ceph-osd: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
Revision history for this message
| Frode Nordahl (fnordahl) wrote | #2 |
| Changed in charm-ceph-osd: | |
| milestone: | none → 18.05 |
| status: | Triaged → Fix Committed |
| assignee: | nobody → James Page (james-page) |
| Changed in charm-ceph-osd: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Well now...
osd-reformat:
type: string
default:
description: |
By default, the charm will not re-format a device that already looks
as if it might be an OSD device. This is a safeguard to try to
prevent data loss.
.
Specifying this option (any value) forces a reformat of any OSD devices
found which are not already mounted.
This is doc'ed but I agree its not super awesome; we should switch this to a boolean IMHO.