Tango skin - Key and Rate down buttons don't respond to right-click

Bug #1752671 reported by Benis
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
ronso0

Bug Description

Have tested this in the latest beta and confirmed it only affects Tango and only affects the down buttons, not the up ones.

Steps to reproduce:
* Load the same track to two decks
* Set them both playing and synchronise them
* Right-click and hold on the down button for key or rate on one deck
* Result: Nothing happens
* Compare with doing the same for the up button
* Result: tracks go slowly out of sync/key of selected track is adjusted upward by 10 cents

Tags: skin
Revision history for this message
Benis (beenisss) wrote :

In res/skins/Tango/rate_pitch_key.xml, lines 32 and 140 are:
<Template src="skin:button_1state.xml">

I think they should actually be:
<Template src="skin:button_1state_right.xml">

Because otherwise the control only responds to left-click. I've updated and rebuilt my local version and that appears to have fixed it.

Changed in mixxx:
assignee: nobody → Benis (beenisss)
Revision history for this message
ronso0 (ronso0) wrote :

Thanks for reporting this.

Right now I'm fixing & polishing some stuff in Tango https://github.com/mixxxdj/mixxx/pull/1531
Since you didn't open a PR yet, I will add those changes there.

Changed in mixxx:
status: New → Confirmed
assignee: Benis (beenisss) → ronso0 (medontknow)
ronso0 (ronso0)
Changed in mixxx:
status: Confirmed → Fix Committed
jus (jus)
Changed in mixxx:
importance: Undecided → Low
milestone: none → 2.1.0
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9163

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.