patch review of gnome-session

[Tim Lunn]

I have had a look through the current gnome-session packaging and there are a number of packages which I would like to drop.

22_support_autostart_delay.patch - This was broken while we were running under upstart user sessions, not sure if it currently works with systemd, however the few apps that may be using it, should probably be using systemd --user sessions?

95_dbus_request_shutdown.patch - This predates the dinosaurs, no idea if anyone is using the dbus API's butthis should all have been superceeded by logind?

export_env_to_upstart.patch - upstart is no longer in the archive, this is no longer needed.

13_display_session_properties.patch and 51_remove_session_saving_from_gui.patch should just be merged into the gnome-session-properties revert patches, if we decide to keep it.

ignore_gsettings_region.patch - should probably be added in debian, unless its specific to ubuntu specific patches in accountsservice or so?

[Sebastien Bacher (seb128)]

Thanks Tim for reviewing those, some comments

* 22_support_autostart_delay.patch,

It's still useful and easy to maintain, let's keep it at least until the LTS. We don't have systemd user session yet, when we do (likely next cycle) then we can drop the patch and move from autostart to user jobs.

* 95_dbus_request_shutdown.patch,

unsure where it's used but it's easy to keep so let's avoid surprises by dropping it just before the LTS and do that next cycle?

* export_env_to_upstart.patch

seems fine to drop

[Tim Lunn (darkxst)]

Yes it probably makes sense to wait until after the LTS to drop those. Will revisit early next cycle.

I have dropped the upstart patch on bzr branch for now.