Update tags for QoS policy failed

Bug #1751984 reported by Dongcan Ye
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack SDK
Fix Released
Undecided
Dongcan Ye

Bug Description

$ openstack network qos policy create test
+-------------+--------------------------------------+
| Field | Value |
+-------------+--------------------------------------+
| description | |
| id | 16088664-18c8-4722-981e-0d852fd37343 |
| is_default | False |
| name | test |
| project_id | 67f5a69dc9ac4983bd5072d2ee302ec3 |
| rules | [] |
| shared | False |
+-------------+--------------------------------------+

$ curl -g -i -X PUT http://20.30.40.5:9696/v2.0/qos/policies/16088664-18c8-4722-981e-0d852fd37343/tags -H "User-Agent: osc-lib/1.9.0 keystoneauth1/3.4.0 python-requests/2.18.4 CPython/2.7.12" -H "Content-Type: application/json" -H "X-Auth-Token: gAAAAABalNw0b6n88tsaJfUwB33PXMDJmHAcNRYB5Vomf0Q3-d5NQ2esV3bELJWXhM2basoVK7VQ-hAVqBV4cLZ1mmVstY6eD3BZ2gEOycm1sJo5QqvBy3u0-sUBQw1lBeL67eRkeVrgB5JrcCp2sRxLMN65cwtm6Aha8_JuFqIBRoNt-n_gxLg" -d '{"tags": ["test1"]}'
HTTP/1.1 400 Bad Request
Content-Type: application/json
Content-Length: 118
X-Openstack-Request-Id: req-9f011921-3321-4d65-a3a4-cc04a9f87bdb
Date: Tue, 27 Feb 2018 04:21:21 GMT

{"NeutronError": {"message": "Invalid input for operation: Invalid tags body.", "type": "InvalidInput", "detail": ""}}

Dongcan Ye (hellochosen)
Changed in neutron:
assignee: nobody → Dongcan Ye (hellochosen)
description: updated
Dongcan Ye (hellochosen)
affects: neutron → python-openstackclient
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

@Dongcan Ye: why You changed it to python-openstackclient? From original bug report it looks like errors is returned from neutron-server even when call is done with curl

Revision history for this message
Dongcan Ye (hellochosen) wrote :

Hi, Slawek. After investigation I found it's a bug of python-openstacksdk, we pass wrong url(/qos/policies).
In Neutron, the resource is "policies". [1]
[1] https://developer.openstack.org/api-ref/network/v2/

affects: python-openstackclient → python-openstacksdk
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-openstacksdk (master)

Fix proposed to branch: master
Review: https://review.openstack.org/548207

Changed in python-openstacksdk:
status: New → In Progress
Revision history for this message
Slawek Kaplonski (slaweq) wrote :

ok, thx a lot for explanation and for working on that :)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-openstacksdk (master)

Change abandoned by Dongcan Ye (<email address hidden>) on branch: master
Review: https://review.openstack.org/548207

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-openstacksdk (master)

Reviewed: https://review.openstack.org/547372
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=7b6d71d206712ab7b5f6ab1ae5eaa85b1926b4fd
Submitter: Zuul
Branch: master

commit 7b6d71d206712ab7b5f6ab1ae5eaa85b1926b4fd
Author: Dongcan Ye <email address hidden>
Date: Fri Feb 23 10:56:30 2018 +0000

    Network: Add tag support for QoS policy

    This patch adds set tags operation and query parameters
    for QoS policy.

    Meanwhile overwrite set_tags for QoS policy,
    The resource type for QoS policy tagging should be
    'policies'.

    Change-Id: I7f7025c3c86fbbe3bfae992ed23352e37257ea64
    Partial-Bug: #1750987
    Closes-Bug: #1751984

Changed in python-openstacksdk:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-openstacksdk 0.12.0

This issue was fixed in the openstack/python-openstacksdk 0.12.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.