Canonical Juju

Data Race in github.com/juju/juju/worker/provisioner provisioner_test.go:1461: ProvisionerSuite.TestStopInstancesIgnoresMachinesWithKeep

Bug #1751863 reported by John A Meinel on 2018-02-26

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Canonical Juju	Fix Released	High	John A Meinel	Canonical Juju 2.3.5

Bug Description

As seen here:
http://10.125.0.203:8080/job/RunUnittests-race-amd64/134/console

Seems to be in the 2.3 branch and not the 2.4 (develop). Might be already fixed in develop, and we just need to backport the change. Might be that the test is just written differently.

==================
WARNING: DATA RACE
Write at 0x00c4207922d0 by goroutine 137:
  runtime.mapassign_faststr()
      /snap/go/1404/src/runtime/hashmap_fast.go:774 +0x0
  github.com/juju/juju/worker/provisioner_test.(*mockBroker).StartInstance()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1988 +0x31f
  github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachine()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:1057 +0x3b8
  github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachines.func1()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:906 +0x9a

Previous read at 0x00c4207922d0 by goroutine 72:
[failed to restore the stack]

Goroutine 137 (running) created at:
  github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:904 +0x4f7
  github.com/juju/juju/worker/provisioner.(*provisionerTask).processMachines()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:309 +0x987
  github.com/juju/juju/worker/provisioner.(*provisionerTask).loop()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:179 +0x55a
  github.com/juju/juju/worker/provisioner.(*provisionerTask).(github.com/juju/juju/worker/provisioner.loop)-fm()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:111 +0x41
  github.com/juju/juju/worker/catacomb.runSafely()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:289 +0x70
  github.com/juju/juju/worker/catacomb.Invoke.func3()
      /workspace/src/github.com/juju/juju/worker/catacomb/catacomb.go:116 +0x8e

Goroutine 72 (running) created at:
  gopkg.in/check%2ev1.(*suiteRunner).forkCall()
      /workspace/src/gopkg.in/check.v1/check.go:663 +0x430
  gopkg.in/check%2ev1.(*suiteRunner).forkTest()
      /workspace/src/gopkg.in/check.v1/check.go:754 +0x131
  gopkg.in/check%2ev1.(*suiteRunner).runTest()
      /workspace/src/gopkg.in/check.v1/check.go:809 +0x42
  gopkg.in/check%2ev1.(*suiteRunner).run()
      /workspace/src/gopkg.in/check.v1/check.go:615 +0x1fa
  gopkg.in/check%2ev1.Run()
      /workspace/src/gopkg.in/check.v1/run.go:92 +0x5a
  gopkg.in/check%2ev1.RunAll()
      /workspace/src/gopkg.in/check.v1/run.go:84 +0x136
  gopkg.in/check%2ev1.TestingT()
      /workspace/src/gopkg.in/check.v1/run.go:72 +0x680
  github.com/juju/testing.MgoTestPackage()
      /workspace/src/github.com/juju/testing/mgo.go:467 +0x120
  github.com/juju/juju/testing.MgoTestPackage()
      /workspace/src/github.com/juju/juju/testing/mgo.go:19 +0x41
  github.com/juju/juju/worker/provisioner_test.TestPackage()
      /workspace/src/github.com/juju/juju/worker/provisioner/package_test.go:13 +0x38
  testing.tRunner()
      /snap/go/1404/src/testing/testing.go:746 +0x16c
==================
==================
WARNING: DATA RACE
Write at 0x00c42024a098 by goroutine 137:
  github.com/juju/juju/worker/provisioner_test.(*mockBroker).StartInstance()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_test.go:1988 +0x338
  github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachine()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:1057 +0x3b8
  github.com/juju/juju/worker/provisioner.(*provisionerTask).startMachines.func1()
      /workspace/src/github.com/juju/juju/worker/provisioner/provisioner_task.go:906 +0x9a

Previous read at 0x00c42024a098 by goroutine 72:
[failed to restore the stack]

Revision history for this message

John A Meinel (jameinel) wrote on 2018-02-27:

https://github.com/juju/juju/pull/8432

is the PR against 2.3

Changed in juju:
assignee:	nobody → John A Meinel (jameinel)
status:	Triaged → In Progress

Canonical Juju QA Bot (juju-qa-bot) on 2018-02-27

Changed in juju:
milestone:	2.3.4 → 2.3.5

John A Meinel (jameinel) on 2018-02-28

Changed in juju:
status:	In Progress → Fix Committed

Revision history for this message

John A Meinel (jameinel) wrote on 2018-02-28:

merge into 2.4/develop: https://github.com/juju/juju/pull/8437

Canonical Juju QA Bot (juju-qa-bot) on 2018-03-28

Changed in juju:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.