Rescue-Backup of Symbol Remap fails when subfolders are used in the project

[Andrey Kuznetsov]

When the project has a hierarchy sheet that's inside a subfolder, the remapping of symbols process creates a rescue backup before modifying the files. The rescue backup fails to backup the subfolders in which the hierarchy sheets are stored.

I think Wayne might have mentioned something a year ago about not supporting subfolders, but reality is that it got fixed without file format modification and it works, and since it works, the rescue-backup should try not to break it.

Screenshot attached of the error.

Using:
Application: kicad
Version: (5.0.0-rc2-dev-1-g21f46776c), release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Wayne Stambaugh (stambaughw)]

@Andrey, would you please attach the project (prior to remapping) that caused the problem or at least a sample project that triggers the issue? I'm really busy right now and I do not have any projects that trigger this bug.

[Andrey Kuznetsov (kandrey89)]

Open the project file, then open the schematic file, click Remap, then click Continue with Rescue, then it throws the error.

[Wayne Stambaugh (stambaughw)]

@Andrey, thanks for the sample project. I see now where I made my mistake. I will attempt to get this fixed in the next day or so.

[KiCad Janitor (kicad-janitor)]

Fixed in revision ce1bd4c6b7e43eb8d4aadbabff5b1338bb0abf2c
https://git.launchpad.net/kicad/patch/?id=ce1bd4c6b7e43eb8d4aadbabff5b1338bb0abf2c

[Wayne Stambaugh (stambaughw)]

I just pushed a fix for this. Please let me know if you are still having any issues.