Warp on locate behavior is different between legacy and GAL

[Jon Evans]

In Legacy, when you locate a component (e.g. by using find dialog), it centers the display on the component but does not zoom.

In GAL, it centers and zooms, and the zoom level is not controllable.

We should add a checkbox to the find dialog that toggles whether or not to zoom (and maybe one that toggles whether or not to center, too)

(reported on forum, https://forum.kicad.info/t/zoom-after-find/5394 )

[Jon Evans (craftyjon)]

Confirmed on recent master
Application: pcbnew
Version: (5.0-dev-4161-gab3b85b14-dirty), debug build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.55.1 OpenSSL/1.0.2g zlib/1.2.11 libidn2/2.0.2 libpsl/0.18.0 (+libidn2/2.0.2) librtmp/2.3
Platform: Linux 4.13.0-32-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    Curl: 7.55.1
    Compiler: GCC 7.2.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Jon Evans (craftyjon)]

Patch attached to fix this.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 88fb4c57e51ebafdc9194469b2eb35aeb9c8271a
https://git.launchpad.net/kicad/patch/?id=88fb4c57e51ebafdc9194469b2eb35aeb9c8271a

[Maciej Suminski (orsonmmz)]

Thanks Jon, I have committed your patch.