Transition cfgm_common to tox

Bug #1751438 reported by Krzysztof Klimonda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
In Progress
Low
Krzysztof Klimonda
OpenContrail
New
Low
Unassigned

Bug Description

We've been hitting python-related issues with cfgm_common library (impossible to install geventhttpclient from pypi, too old setuptools version to install other libraries) and instead of fixing them one-by-one, rewrite cfgm_common to use tox the same way contrail-api-server does.

At the same time we'll transition SetupPyTestSuiteWithDeps to use generic targets as dependencies instead of file paths.

Tags: config
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40072
Submitter: Krzysztof Klimonda (<email address hidden>)

3 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

1 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40074
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40072
Submitter: Krzysztof Klimonda (<email address hidden>)

1 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

3 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40072
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40166
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40074
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

6 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40072
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40073
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

2 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40072
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

2 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40166
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

30 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40381
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

3 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40378
Committed: http://github.com/Juniper/contrail-controller/commit/131d56aad54bf51c2b94e6ddcb51ee5bf6876bd5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 131d56aad54bf51c2b94e6ddcb51ee5bf6876bd5
Author: Krzysztof Klimonda <email address hidden>
Date: Wed Mar 7 10:11:35 2018 +0100

Disable cfgm_common tests

Those tests are failing, and until the review that fixes the failure can
be merged, disable those tests to fix build failures.

Also, add a workaround for svc-monitor not running - we'll add a proper
fix after review 40381 is merged.

This is part of a patch series rewriting cfgm_common to tox:

0. Various misc test failure fixes <-- here
1. fix SCons directory dependencies
2. add support for generic scons targets to rules.py
3. rewrite cfgm_common to use tox and add generic targets
4. remove rules.py support for using files as dependencies

Partial-Bug: #1751438
Change-Id: Ic7fe446b13dc91587292237ed665be2fb2e09a0a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40166
Committed: http://github.com/Juniper/contrail-common/commit/06322c1eaa7ae7c36bd3d5888c34f19944ede91e
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 06322c1eaa7ae7c36bd3d5888c34f19944ede91e
Author: Krzysztof Klimonda <email address hidden>
Date: Wed Feb 28 10:51:15 2018 +0100

Change SCons dependency to file instead of directory

SCons does not support directories as targets, and they lead to hard to
track bugs. Instead of depending on the directory, depend on the tarball
being created there.

Also, add an ":sdist" target for pysandesh, to match other sdist
targets.

This is part of a patch series rewriting cfgm_common to tox:

1. fix SCons directory dependencies <-- here
2. add support for generic scons targets to rules.py
3. rewrite cfgm_common to use tox and add generic targets
4. remove rules.py support for using files as dependencies

Depends-On: Ic7fe446b13dc91587292237ed665be2fb2e09a0a
Change-Id: Ie459d7472e5f670ba94439de6173ffc1e9ea1f93
Partial-Bug: #1751438

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40073
Committed: http://github.com/Juniper/contrail-build/commit/c3315f82bf934bdfa8c2627526a187657e0b89e9
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c3315f82bf934bdfa8c2627526a187657e0b89e9
Author: Krzysztof Klimonda <email address hidden>
Date: Fri Feb 23 23:12:20 2018 +0100

Transition SetupPyTestSuiteWithDeps to generic dependencies

Rewrite dependency handling in SetupPyTestSuiteWithDeps so that
we don't have to hardcode file paths, and can use generic targets
instead. This helps us remove some cruft around api-server version,
and adds support for potential versioning of other python modules.

This is part of a patch series rewriting cfgm_common to tox:

1. fix SCons directory dependencies
2. add support for generic scons targets to rules.py <-- here
3. rewrite cfgm_common to use tox and add generic targets
4. remove rules.py support for using files as dependencies

Partial-Bug: #1751438
Depends-On: Ie459d7472e5f670ba94439de6173ffc1e9ea1f93
Change-Id: I9d9b29fac8886e8c73a96bc2697d8db6b4dfeb32

Jeba Paulaiyan (jebap)
tags: added: config
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40052
Submitter: Krzysztof Klimonda (<email address hidden>)

Abhay Joshi (abhayj)
Changed in opencontrail:
importance: Undecided → Low
2 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/49523
Submitter: Édouard Thuleau (<email address hidden>)

6 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/49523
Submitter: Michal Krawczyk (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/49523
Submitter: Édouard Thuleau (<email address hidden>)

17 comments hidden view all 110 comments
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/49523
Submitter: Sajeesh Mathew (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/49523
Submitter: Mithun Mistry (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/49523
Committed: http://github.com/Juniper/contrail-controller/commit/0aa06ca6dcdbe17624f9fdfb708cce40037071e2
Submitter: Mithun Mistry (<email address hidden>)
Branch: master

commit 0aa06ca6dcdbe17624f9fdfb708cce40037071e2
Author: Krzysztof Klimonda <email address hidden>
Date: Fri Feb 23 21:07:28 2018 +0100

[config] Rewrite cfgm_common to use tox for tests

Replace one-off python test handling code from SCons with a common tox runner.
Also renames the contrail config common python package from 'cfgm_common'
to 'contrail-config-common' but keeps the same path name for the python module.

Change-Id: I2c6c7e3eb664e51abea220995a3f686918918fa2
Partial-Bug: #1751438
Closes-Jira-Bug: JCB-166614

Displaying first 40 and last 40 comments. View all 110 comments or add a comment.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.