tripleo-ansible-inventory won't show a traceback during exception handling

[James Slagle]

This exception handling in tripleo-ansible-inventory is too high level:

https://github.com/openstack/tripleo-validations/blob/master/scripts/tripleo-ansible-inventory#L146

The write_static_inventory function could raise any number of exceptions, such as a KeyError or IndexError. When this happens, there are not enough details in the error message produced by this exception handling to tell what the problem is.

At the very least, if we pass --debug to tripleo-ansible-inventory, it should print a traceback in this exception handling.

Even better would be to have some more detailed error reporting throughout the code.

[James Slagle (james-slagle)]

also at this line:

https://github.com/openstack/tripleo-validations/blob/master/scripts/tripleo-ansible-inventory#L153

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/548074

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/548074
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=5d30a5aa8e1510d169c042d25eff26658d96088c
Submitter: Zuul
Branch: master

commit 5d30a5aa8e1510d169c042d25eff26658d96088c
Author: Jill Rouleau <email address hidden>
Date: Mon Feb 26 10:38:12 2018 -0700

    Improve exceptions in tripleo-ansible-inventory

    Adds a debug flag to surface tracebacks on failures.
    Also removes .message from exceptions, as this is deprecated in 2.6
    and removed in py3.

    Change-Id: I7d2cdc37bd134370ff7edcefa3a4589024d5ce9a
    Closes-Bug: 1751340

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 9.0.0 release.