Web Client Holds Shelf Clearable Holds List

Bug #1751126 reported by Joan Kranich
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
3.0
Fix Released
High
Unassigned

Bug Description

Release 3.0.3

The Clearable Holds list printout includes Holds not yet expired from the Holds Shelf.

In the Holds Shelf function, the list of items on the Holds Shelf loads.
Click Show Clearable Holds.
Click Print Full List.
The list includes Holds with a Shelf Expire Time in the future.
For example, I ran the list today, 2/22/2018, and Holds with a Shelf Expire Time of 3/1/2018 are on the printout.

The screen also does not have sort options when configuring the columns.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I set the importance to High because this has been identified as a showstopper for 1 consortium.

Changed in evergreen:
importance: Undecided → High
status: New → Confirmed
Revision history for this message
Jason Stephenson (jstephenson) wrote :

So, here's a branch for this that I've been holding off pushing. It changes the Print Full List button handler code to be aware of the state of the Show Clearable Holds button.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1751126-print-clearable-holds

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.2-beta
Dawn Dale (ddale)
Changed in evergreen:
assignee: nobody → Dawn Dale (ddale)
Revision history for this message
Dawn Dale (ddale) wrote :

I have tested this fix and it works as expected. Print Full List when on the Clearable Holds screen only prints the clearable holds.

Revision history for this message
Kathy Lussier (klussier) wrote :

Hi Dawn,
When you finish testing a bug, could you add a signoff in the following manner?:

"I have tested this code and consent to signing off on it with my name, [enter name or consistent alias] and my email address, [enter email address]."

It would also be great if you removed yourself as an assignee and added a signedoff tag.

Thanks so much for testing!
Kathy

Revision history for this message
Dawn Dale (ddale) wrote : Re: [Bug 1751126] Re: Web Client Holds Shelf Clearable Holds List

Sure, no problem!

Dawn Dale
PINES Services Specialist, Circulation
Georgia Public Library Service
1800 Century Place Suite 150
Atlanta, GA 30345
404-235-7136
<email address hidden>

On Tue, May 22, 2018 at 12:34 PM, Kathy Lussier <email address hidden>
wrote:

> Hi Dawn,
> When you finish testing a bug, could you add a signoff in the following
> manner?:
>
> "I have tested this code and consent to signing off on it with my name,
> [enter name or consistent alias] and my email address, [enter email
> address]."
>
> It would also be great if you removed yourself as an assignee and added
> a signedoff tag.
>
> Thanks so much for testing!
> Kathy
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1751126
>
> Title:
> Web Client Holds Shelf Clearable Holds List
>
> Status in Evergreen:
> Confirmed
> Status in Evergreen 3.0 series:
> Confirmed
> Status in Evergreen 3.1 series:
> Confirmed
>
> Bug description:
> Release 3.0.3
>
> The Clearable Holds list printout includes Holds not yet expired from
> the Holds Shelf.
>
> In the Holds Shelf function, the list of items on the Holds Shelf loads.
> Click Show Clearable Holds.
> Click Print Full List.
> The list includes Holds with a Shelf Expire Time in the future.
> For example, I ran the list today, 2/22/2018, and Holds with a Shelf
> Expire Time of 3/1/2018 are on the printout.
>
> The screen also does not have sort options when configuring the
> columns.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/evergreen/+bug/1751126/+subscriptions
>

Revision history for this message
Dawn Dale (ddale) wrote :

"I have tested this code and consent to signing off on it with my name,
Dawn Dale and my email address, <email address hidden>.

tags: added: 49
tags: added: signedoff
removed: 49
Changed in evergreen:
assignee: Dawn Dale (ddale) → nobody
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.2-beta → 3.1.2
no longer affects: evergreen/3.1
Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master, rel_3_1, and rel_3_0. Thanks, Jason and Dawn!

I will open a new bug for the part of this bug report not addressed by the patch, namely, that the pull list columns are not sortable.

Changed in evergreen:
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Revision history for this message
Galen Charlton (gmc) wrote :

Actually, bug 1437104 includes the question of sorting the pull list.

Revision history for this message
Kathy Lussier (klussier) wrote :

Bug 1712854 addresses the sortable holds shelf list as well.

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.