Add "published_global" field to the task execution REST resource

Bug #1751007 reported by Renat Akhmerov
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Eyal B

Bug Description

We now expose "published" that contains all variables published into the branch local storage. Some time ago we added publishing to the workflow global storage. So we need a corresponding field on the REST resource.

Changed in mistral:
milestone: none → rocky-1
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Renat Akhmerov (rakhmerov)
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: rocky-1 → rocky-2
status: Confirmed → Triaged
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: rocky-2 → rocky-3
status: Triaged → Confirmed
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: rocky-3 → stein-1
Dougal Matthews (d0ugal)
Changed in mistral:
milestone: stein-1 → stein-2
Changed in mistral:
milestone: stein-2 → stein-3
Changed in mistral:
milestone: stein-3 → train-1
summary: - Add "published_global" field to the workflow execution REST resource
+ Add "published_global" field to the task execution REST resource
Revision history for this message
Moshe Elisha (melisha) wrote :

Will be good to add some field to support both "publish" and "advanced publish" for all scopes so customers can switch to the new field and completely ignore the old one ("advanced_published" as a temporary name).

For example:

wf:
  tasks:
    A:
      action: std.noop
      publish:
        my_var: 1

will have "advanced_published" like:

        advanced_published:
          branch:
            my_var: 1

Another example:

wf:
  tasks:
    A:
      action: std.noop
      on-success:
        publish:
          branch:
            my_var: "branch value"
          global:
            my_var: "global value"
          atomic:
            counter: <% global(counter) + 1 %>

will have "advanced_published" like:

        advanced_published:
          branch:
            my_var: "branch value"
          global:
            my_var: "global value"
          atomic:
            counter: 5

Changed in mistral:
assignee: Renat Akhmerov (rakhmerov) → Eyal B (eyalb1)
Revision history for this message
Moshe Elisha (melisha) wrote :

A possible name can be "aggregated_publish" / "combined_published" / "final_publish" / ...

Revision history for this message
Moshe Elisha (melisha) wrote :

Also we need to aggregate in case we have publish on both ("on-success" or "on-error") and in "on-complete"

Changed in mistral:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-mistralclient (master)

Reviewed: https://review.opendev.org/678555
Committed: https://git.openstack.org/cgit/openstack/python-mistralclient/commit/?id=4ecb7dc99af49ff28d6f66288a588205c5e6e0cf
Submitter: Zuul
Branch: master

commit 4ecb7dc99af49ff28d6f66288a588205c5e6e0cf
Author: Eyal <email address hidden>
Date: Mon Aug 26 16:56:37 2019 +0300

    Add "published_global" field to the task execution REST resource

    * added a new cli command execution-get-published

    Closes-bug: #1751007
    Change-Id: I72c2986a234a6cac9f3116006b144ffbc9e2467c

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.opendev.org/678530
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=9804e74d52ed14d73e18017ba757786ab3def897
Submitter: Zuul
Branch: master

commit 9804e74d52ed14d73e18017ba757786ab3def897
Author: Eyal <email address hidden>
Date: Mon Aug 26 15:24:25 2019 +0300

    Add "published_global" field to the task execution REST resource

    Closes-bug: #1751007
    Change-Id: I3129846598784aec43d7f97cead1e98251ac774b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 9.0.0.0b1

This issue was fixed in the openstack/mistral 9.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-mistralclient 3.10.0

This issue was fixed in the openstack/python-mistralclient 3.10.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.