overlay of services not in base bundle error

Bug #1749761 reported by Ashley Lai
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Canonical Juju
Fix Released
Medium
Tim Penhey
2.3
Fix Released
Medium
Tim Penhey

Bug Description

overlay a service that is not in the base bundle returns panic signal SIGSEGV error. It should return a more descriptive error from juju if this is not allowed.

$ juju --version
2.3.2-xenial-amd64

$ cat overlay-t1.yaml
applications:
  aodh:

$ juju deploy -m hw62:admin/t1 ./bundle1.yaml --overlay overlay-t1.yaml
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0xf70249]

goroutine 1 [running]:
github.com/juju/juju/cmd/juju/application.processBundleIncludes(0xc4204f8db0, 0x22, 0xc4205d5030, 0x1, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/application/bundle.go:1021 +0xb9
github.com/juju/juju/cmd/juju/application.deployBundle(0xc4204f8db0, 0x22, 0xc4205d5030, 0xc4204c1d30, 0x1, 0x1, 0x0, 0x0, 0x406e5c0, 0xc4202a0cd0, ...)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/application/bundle.go:94 +0x658
github.com/juju/juju/cmd/juju/application.(*DeployCommand).deployBundle(0xc4203be000, 0xc42001dbd0, 0xc4204f8db0, 0x22, 0xc4205d5030, 0x0, 0x0, 0x406e5c0, 0xc4202a0cd0, 0x0, ...)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/application/deploy.go:659 +0xf8
github.com/juju/juju/cmd/juju/application.(*DeployCommand).maybeReadLocalBundle.func1(0xc42001dbd0, 0x406e5c0, 0xc4202a0cd0, 0xc4201535c0, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/application/deploy.go:1019 +0x112
github.com/juju/juju/cmd/juju/application.(*DeployCommand).Run(0xc4203be000, 0xc42001dbd0, 0x0, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/application/deploy.go:893 +0x3f6
github.com/juju/juju/cmd/modelcmd.(*modelCommandWrapper).Run(0xc42011e240, 0xc42001dbd0, 0xc42011e240, 0xc4204c1d70)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/modelcmd/modelcommand.go:374 +0xe3
github.com/juju/juju/cmd/modelcmd.(*baseCommandWrapper).Run(0xc4200f2190, 0xc42001dbd0, 0x0, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/modelcmd/base.go:389 +0xb5
go.(*struct { github.com/juju/juju/cmd/modelcmd.embed·2; github.com/juju/cmd.Command }).Run(0xc4205440c0, 0xc42001dbd0, 0x7f72a0813548, 0xc4205440c0)
 <autogenerated>:325 +0x54
github.com/juju/cmd.(*SuperCommand).Run(0xc42029db00, 0xc42001dbd0, 0xc42001dbd0, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/cmd/supercommand.go:456 +0x2f1
github.com/juju/cmd.Main(0x4059560, 0xc42029db00, 0xc42001dbd0, 0xc420010160, 0x6, 0x6, 0x40405c0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/cmd/cmd.go:317 +0x26f
github.com/juju/juju/cmd/juju/commands.main.Run(0x2c338f0, 0xc420010150, 0x7, 0x7, 0x0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/commands/main.go:173 +0x189
github.com/juju/juju/cmd/juju/commands.Main(0xc420010150, 0x7, 0x7, 0xc42000c5a0)
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/commands/main.go:125 +0x4b
main.main()
 /build/juju-core-j2f6Ga/juju-core-2.3.2/obj-x86_64-linux-gnu/src/github.com/juju/juju/cmd/juju/main.go:32 +0x8c

Revision history for this message
Ashley Lai (alai) wrote :
Changed in juju-core:
status: New → Invalid
Tim Penhey (thumper)
Changed in juju:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Tim Penhey (thumper)
milestone: none → 2.3.4
Revision history for this message
Tim Penhey (thumper) wrote :
John A Meinel (jameinel)
Changed in juju-core:
status: Invalid → Fix Committed
milestone: none → 1.25.14
no longer affects: juju-core
Changed in juju:
status: In Progress → Fix Committed
milestone: 2.3.4 → 2.4-beta1
Changed in juju:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.