Inconsistency in the un-used parameters warning

[Saravanan KR]

In the current deployment the list of un-used parameters are listed as below:
--------------------------------------------------------------------
WARNING: Following parameters are defined but not used in plan. Could be possible that parameter is valid but currently not used.
  ControlPlaneDefaultRoute
  NumDpdkInterfaceRxQueues
  TenantNetCidr
  LocalUnusedNicName
  NeutronDatapathType
  StorageMgmtAllocationPools
  StorageMgmtNetCidr
  NeutronVhostuserSocketGroup
  DockerMysqlClientConfigImage
  TenantNetworkVlanID
  ExternalNetCidr
  StorageMgmtNetworkVlanID
  TenantAllocationPools
  ExternalAllocationPools
  InternalApiNetworkVlanID
  InternalApiNetCidr
  DnsServers
  StorageAllocationPools
  StorageNetCidr
  StorageNetworkVlanID
  LocalProvisioningNicName
  EC2MetadataIp
  ComputeSriovCount
  OvercloudComputeSriovFlavor
  ExternalInterfaceDefaultRoute
  InternalApiAllocationPools
  NeutronVhostuserSocketDir
--------------------------------------------------------------------

This output is wrong as some of the parameters are used by nic configs and services. Somehow the cache is updated at wrong time.

When the workflow is executed as standalone or when the cache is invalidated during GetFlattenedParametersAction the list of un-used parameters are as below
--------------------------------------------------------------------
WARNING: Following parameters are defined but not used in plan. Could be possible that parameter is valid but currently not used.
  DockerMysqlClientConfigImage
  ComputeSriovCount
  OvercloudComputeSriovFlavor
--------------------------------------------------------------------

This output is correct as per the current deployment configuration.

Figure out why the cache is updated at the wrong instance.
https://github.com/openstack/python-tripleoclient/blob/50662be1709de49da3e22ac44e8f249e159d1a7c/tripleoclient/v1/overcloud_deploy.py#L348

[Saravanan KR (skramaja)]

The parameters present in the files uploaded by _upload_missing_files() function tripleoclient are missing the resource parameters output.

tarted Mistral Workflow tripleo.plan_management.v1.update_deployment_plan. Execution ID: 1af02e7a-0e26-48c5-8d77-2aa4491f9688
Plan updated.
Processing templates in the directory /tmp/tripleoclient-2Wkrfh/tripleo-heat-templates
KRS: reloc_path: user-files/home/stack/osp13_ref/nic-configs/computesriov.yaml
KRS: reloc_path: user-files/home/stack/osp13_ref/nic-configs/computeovsdpdk.yaml
KRS: reloc_path: user-files/home/stack/osp13_ref/common/first-boot.yaml
KRS: reloc_path: user-files/home/stack/osp13_ref/nic-configs/controller.yaml
KRS: reloc_path: user-files/usr/share/openstack-tripleo-heat-templates/network/scripts/run-os-net-config.sh
KRS: reloc_path: user-files/home/stack/osp13_ref/common/post-install.yaml
KRS: Updating paramters

There is some mismatch between the files upload and the heat validation triggered from the UpdateParametersAction. Still looking.

[Saravanan KR (skramaja)]

user-environment.yaml is missing in the environment of plan-env

At the time of UpdateParametersAction intiated from tripleoclient
---------------------------------------
[{"path": "overcloud-resource-registry-puppet.yaml"}, {"path": "environments/docker.yaml"}, {"path": "environments/docker-ha.yaml"}, {"path": "environments/containers-default-parameters.yaml"}]

At the time of GetFlattenedParametersAction (when cache is invalidated for testing)
----------------------------------------------------
[{"path": "overcloud-resource-registry-puppet.yaml"}, {"path": "environments/docker.yaml"}, {"path": "environments/docker-ha.yaml"}, {"path": "environments/containers-default-parameters.yaml"}, {"path": "user-environment.yaml"}]

Trying to figure out why is it missing during the UpdateParametersAction.

[Saravanan KR (skramaja)]

https://review.openstack.org/#/c/534337/ fixes the issue.