qlog seems hang when invoking qdiff for very big tree

Bug #174964 reported by Vitaliy Lotorev
4
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Medium
Lukáš Lalinský

Bug Description

Problem:

Double-clicking on any revision usually opens qdiff window. For very big tree with many changes qdiff window opens with very big delay. During this dealy qlog seems hang.

Original message:

I have windows xp, Bazaar (bzr) 1.0.0.candidate.1 and qbzr 0.8 installed.
'bzr qlog' in cmd.exe shows me a dialog with branch log in current directory.
Double click on any revision line produces "QCoreApplication::exec The event loop is already running" line appearing in cmd.exe infinitely.
In some cases QBzr dialog simply hangs without printing the above message in cmd.exe.

Tags: qdiff qlog

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 174964] qlog. double click doesn't work anyhow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

lotorev vitaly пишет:
> I have windows xp, Bazaar (bzr) 1.0.0.candidate.1 and qbzr 0.8 installed.

What version of bzr you are using: standalone bzr.exe or python-based?
In the latter case something wrong with your PyQt4 installation, I think.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHWxZ4zYr338mxwCURAtNEAKCRpXX9j9+5qSUh9u3hFC4SKBnAMwCfdpAi
h777Tl41Ckroek+FSXXCOIY=
=JGpp
-----END PGP SIGNATURE-----

Revision history for this message
Vitaliy Lotorev (lotorev) wrote : Re: qlog. double click doesn't work anyhow

Just tried on second machine. and got the same result. Qlog hungs after double click on every revision line

I have both bzr and qbzr standalone installed.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 174964] Re: qlog. double click doesn't work anyhow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

lotorev vitaly пишет:
> Just tried on second machine. and got the same result. Qlog hungs after
> double click on every revision line
>
> I have both bzr and qbzr standalone installed.

I'll try this on clean machine (usually I have Python+PyQt lib installed) may be we need to bundle
some additional library.

Can you check one more test: select some revision in qlog and press button in left bottom corner
(for English locale it's named "Diff", for Russian locale it's "Различия"). Does you will have
the same error in this case?

Your case is very strange, because I'm using QBzr standalone 0.8.0 too on Windows XP Home without
problems. But I think I need to check this behavior on clean machine.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXCIDzYr338mxwCURAn8eAJ4uYQhq93BTBLUCJuqljngqOSzViACfbQHp
re0OOCdQV8O9gvmHd+APsfw=
=Rem2
-----END PGP SIGNATURE-----

Revision history for this message
Vitaliy Lotorev (lotorev) wrote : Re: qlog. double click doesn't work anyhow

I seem to have understood the problem, hmmm... my problem.
I've just started to fiddle with bzr. My first experimental branch has around new 300 files. so Diff between revision is huge. After two minutes of 'hanging' qlog showed the difference for all 300 files. So it works correctly.

Now I performed " bzr branch http://bazaar-vcs.org/bzr/bzr.dev bzr.dev " to get bzr trunk to try on another branch.
On this branch Qlog works the way it must.

The only thing I don't understand is the message "QCoreApplication::exec The event loop is already running". I did have it yesterday, but now I can't repeat it, even on my own branch.

Probably it's a good idea to warn user that it can take time to build Diff, but it's probably impossible to estimate in advance how many differences there are between revisions user chose.

Revision history for this message
Alexander Belchenko (bialix) wrote : Re: [Bug 174964] Re: qlog. double click doesn't work anyhow

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

lotorev vitaly пишет:
> I seem to have understood the problem, hmmm... my problem.
> I've just started to fiddle with bzr. My first experimental branch has around new 300 files. so Diff between revision is huge. After two minutes of 'hanging' qlog showed the difference for all 300 files. So it works correctly.
>
> Now I performed " bzr branch http://bazaar-vcs.org/bzr/bzr.dev bzr.dev " to get bzr trunk to try on another branch.
> On this branch Qlog works the way it must.
>
> The only thing I don't understand is the message "QCoreApplication::exec
> The event loop is already running". I did have it yesterday, but now I
> can't repeat it, even on my own branch.
>
> Probably it's a good idea to warn user that it can take time to build
> Diff, but it's probably impossible to estimate in advance how many
> differences there are between revisions user chose.

As variant we can show [empty] diff window and some sort of progress bar to inform user about work
in progress.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHXF4GzYr338mxwCURAprWAJ91Qhwt7OAGyfSunrHqREfXlpUBHACeNCyH
zOfOz9FDPXY9FJ/CzHs8i90=
=r0/x
-----END PGP SIGNATURE-----

description: updated
Changed in qbzr:
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Alexander Belchenko (bialix) wrote :

We need some sort of progress bar or even simply "Please wait" message as workaround for this.

Changed in qbzr:
milestone: none → 1.0
status: Confirmed → Triaged
Changed in qbzr:
assignee: nobody → garyvdm
Changed in qbzr:
assignee: garyvdm → luks
Changed in qbzr:
milestone: 1.0 → 0.9.2
status: Triaged → Fix Committed
Changed in qbzr:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.