enable_ssh_admin workflow fails if there are any failed servers in nova

[Brent Eagles]

The get_servers task uses the mistral nova.servers_list action that returns all of the nodes in the overcloud. If something failed to provision/startup but there were enough nodes to continue deployment then the task will fail because the failed node will be included in the query results. The failed node will probably not have control plane IP address so attempting to access it breaks the YAQL expression.

[Brent Eagles (beagles)]

Proposed patch:
https://review.openstack.org/#/c/539245/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664928
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=718a7b176f5b903619723432c92d140e9c2844ac
Submitter: Zuul
Branch: stable/rocky

commit 718a7b176f5b903619723432c92d140e9c2844ac
Author: Brent Eagles <email address hidden>
Date: Tue Jan 30 12:45:22 2018 -0330

    Handle failed nodes when enabling ssh admin

    Filter server list by state before selecting by control plane address to
    avoid YAQL expression issues.

    Closes-Bug: #1749450
    Change-Id: I0ae383105bc5d8849a733bfbe5bd61fb3fc24c66
    (cherry picked from commit 3933a66c88293efc016444f04fa92b3c7c3b863a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 9.6.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664929
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=587da83e57eecb14a36f54db9a8f488977a7a044
Submitter: Zuul
Branch: stable/queens

commit 587da83e57eecb14a36f54db9a8f488977a7a044
Author: Brent Eagles <email address hidden>
Date: Tue Jan 30 12:45:22 2018 -0330

    Handle failed nodes when enabling ssh admin

    Filter server list by state before selecting by control plane address to
    avoid YAQL expression issues.

    Closes-Bug: #1749450
    Change-Id: I0ae383105bc5d8849a733bfbe5bd61fb3fc24c66
    (cherry picked from commit 3933a66c88293efc016444f04fa92b3c7c3b863a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.7.1 release.