OVB ocata jobs fail because of wrong command overcloud container image prepare

[Sagi (Sergey) Shnaidman]

"overcloud container image prepare" seems not exists in ocata:

https://logs.rdoproject.org/38/543638/1/openstack-check/gate-tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001-ocata-branch/Z9456ad993757466696bd92322d107e5b/undercloud/home/jenkins/undercloud_prep_containers.log.txt.gz

2018-02-13 06:39:48 | openstack: 'overcloud container image prepare --output-env-file /home/jenkins/undercloud-containers-default-parameters.yaml --template-file /usr/share/openstack-tripleo-common/container-images/overcloud_containers.yaml.j2 -e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/mistral.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/ironic.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/ironic-inspector.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/services-docker/zaqar.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml -r /usr/share/openstack-tripleo-heat-templates/roles_data_undercloud.yaml --namespace docker.io/tripleoocata --tag a081db24c546edb189738376f584155f349060ed_e0df978b' is not an openstack command. See 'openstack --help'.
2018-02-13 06:39:48 | Did you mean one of these?
2018-02-13 06:39:48 | overcloud delete
2018-02-13 06:39:48 | overcloud deploy
2018-02-13 06:39:48 | overcloud execute
2018-02-13 06:39:48 | overcloud generate fencing
2018-02-13 06:39:48 | overcloud image build
2018-02-13 06:39:48 | overcloud image upload
2018-02-13 06:39:48 | overcloud netenv validate
2018-02-13 06:39:48 | overcloud node configure
2018-02-13 06:39:48 | overcloud node delete
2018-02-13 06:39:48 | overcloud node import
2018-02-13 06:39:48 | overcloud node introspect
2018-02-13 06:39:48 | overcloud node provide
2018-02-13 06:39:48 | overcloud parameters set
2018-02-13 06:39:48 | overcloud plan create
2018-02-13 06:39:48 | overcloud plan delete
2018-02-13 06:39:48 | overcloud plan deploy
2018-02-13 06:39:48 | overcloud plan list
2018-02-13 06:39:48 | overcloud profiles list
2018-02-13 06:39:48 | overcloud profiles match
2018-02-13 06:39:48 | overcloud raid create
2018-02-13 06:39:48 | overcloud update clear breakpoints
2018-02-13 06:39:48 | overcloud update stack
2018-02-13 06:39:48 | undercloud install
2018-02-13 06:39:48 | undercloud upgrade

[Sagi (Sergey) Shnaidman (sshnaidm)]

The problem was introduced in that patch: https://review.openstack.org/#/c/517444/

[Bogdan Dobrelya (bogdando)]

https://review.openstack.org/#/c/543861/

[Bogdan Dobrelya (bogdando)]

with the patch, OVB ocata job is passing

[Sagi (Sergey) Shnaidman (sshnaidm)]

I'm fixing it here: https://review.openstack.org/#/c/543893/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Bogdan Dobrelya (<email address hidden>) on branch: master
Review: https://review.openstack.org/543861
Reason: https://review.openstack.org/#/c/543893/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/543893
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=0cfbdb5435ce232b122b490fd6e688dd75849345
Submitter: Zuul
Branch: master

commit 0cfbdb5435ce232b122b490fd6e688dd75849345
Author: Sagi Shnaidman <email address hidden>
Date: Tue Feb 13 13:07:02 2018 +0200

    Run undercloud containers only when containerized_undercloud

    Don't run undercloud containers when it's not supported or
    not configured.
    Problem was introduced in I7d056b208d5ac0639e3277f3f4ae453a9ee639e8
    Close-Bug: #1749105
    Change-Id: If6fcb63da21a4c4b087a72159a2d422b2c58291e