FFU upgrade: openstack overcloud config download fails with: Deployment NetworkDeployment with group:os-apply-config not supported with config-download

[James Slagle]

FFU upgrade: openstack overcloud config download fails with: Deployment NetworkDeployment with group:os-apply-config not supported with config-download

FFU upgrade: openstack overcloud config download fails with: Deployment NetworkDeployment with group:os-apply-config not supported with config-download

Steps to reproduce:

1. Deploy OSP10 undercloud + overcloud
2. Upgrade undercloud to OSP11
3. Upgrade undercloud to OSP12
4. Upgrade undercloud to OSP13
5. Update stack outputs:
openstack overcloud deploy \
--disable-validations \
--templates /usr/share/openstack-tripleo-heat-templates \
-e /usr/share/openstack-tripleo-heat-templates/environments/puppet-pacemaker.yaml \
--libvirt-type kvm \
--ntp-server clock.redhat.com \
--control-scale 1 \
--control-flavor controller \
--compute-scale 1 \
--compute-flavor compute \
-e /home/stack/virt/config_lvm.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml \
-e /home/stack/virt/network/network-environment.yaml \
-e /home/stack/virt/hostnames.yml \
-e /home/stack/virt/debug.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/docker-ha.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/fast-forward-upgrade.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/noop-deploy-steps.yaml \
-e /usr/share/openstack-tripleo-heat-templates/environments/config-download-environment.yaml \
-e /home/stack/docker_registry.yaml \

6. (undercloud) [stack@undercloud-0 ~]$ openstack overcloud config download

Deployment NetworkDeployment with group:os-apply-config not supported with config-download.

The nic templates in use on the overcloud do contain group: os-apply-config properties which were supported during OSP10 deployment. Here is the nic template for the controller role:

http://paste.openstack.org/show/645040/

config download works fine if before updating the stack outputs the nic templates are adjusted to use group: script. I think we need to provide a migration path(some script?) from old nic templates to the new required format because having to manually edit the nic templates is error prone and provides a terrible user experience.

[James Slagle (james-slagle)]

https://review.openstack.org/543976

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/543976

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/543976
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=b782c388c7c893c98fb7518e1208a30c9c795a0a
Submitter: Zuul
Branch: master

commit b782c388c7c893c98fb7518e1208a30c9c795a0a
Author: James Slagle <email address hidden>
Date: Tue Feb 13 10:45:02 2018 -0500

    Deprecate group:os-apply-config with config-download

    Instead of throwing an exception when a group:os-apply-config deployment
    is found with config-download, just show a deprecation warning instead.
    This will allow FFU to move forward without forcing users to update
    older nic config templates that still use group:os-apply-config.

    Change-Id: Icc803605b88d0655bfd45bdf1521298229a4722e
    Closes-Bug: #1748976

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.5.0 release.