Designate::Record resources can make stack undeletable

[Pavlo Shchelokovskyy]

In case the Designate Zone is managed outside of a heat stack that has Designate::Record resources defined that reference this zone, deleting the zone makes the stack undeletable.

The reason is the heat's designate client plugin during record deletion resolves the zone first, and when failed to do so the actual exception will be heat's EntityNotFound instead of designate's NotFound (which is the only exception checked by ignore_not_found in designate client plugin).

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/543585

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/543585
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=55a7492c6c530130db93baca1b69d5521c2c5d45
Submitter: Zuul
Branch: master

commit 55a7492c6c530130db93baca1b69d5521c2c5d45
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Mon Feb 12 20:48:32 2018 +0200

    Ignore dns domain NotFound when deleting record

    when the domain is deleted, all its records are deleted as well.
    Not ignoring such NotFound can lead to undeletable stacks if they
    have a Designate::Record resource that references a deleted Designate
    Domain.

    Change-Id: If56f84b0b86f4d8136a1f83683a4a9eee5d89759
    Closes-Bug: #1748953

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 11.0.0.0b2 development milestone.