image-create header is static

Bug #1748559 reported by Brian Rosmaita
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Brian Rosmaita

Bug Description

Part of interoperable image import is that the image-create response should return a 'OpenStack-image-import-methods' header containing the list of methods supported by that cloud. Currently, it always returns 'glance-direct'. It needs to populate the header from the enabled_image_methods configuration setting.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/543039

Changed in glance:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/543039
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=3712dccfdb7ee30243e4efc09fcad1c3197bdb51
Submitter: Zuul
Branch: master

commit 3712dccfdb7ee30243e4efc09fcad1c3197bdb51
Author: Brian Rosmaita <email address hidden>
Date: Fri Feb 9 17:12:31 2018 -0500

    Use configured value for import-methods header

    In Image API v2.6, the image-create response returns an
    'OpenStack-image-import-methods' header containing a list of
    methods available in that cloud. This patch populates that
    list from the enabled_import_methods configuration setting.
    Following RFC 7230, if the enabled_import_methods is empty,
    the header is not returned with the response.

    Change-Id: I3066da36a0fbb83fe492bddb193975e42ffc5084
    Closes-bug: #1748559

Changed in glance:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/543613

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/queens)

Reviewed: https://review.openstack.org/543613
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=235713eade43912658ca250fec5bea222c626a85
Submitter: Zuul
Branch: stable/queens

commit 235713eade43912658ca250fec5bea222c626a85
Author: Brian Rosmaita <email address hidden>
Date: Fri Feb 9 17:12:31 2018 -0500

    Use configured value for import-methods header

    In Image API v2.6, the image-create response returns an
    'OpenStack-image-import-methods' header containing a list of
    methods available in that cloud. This patch populates that
    list from the enabled_import_methods configuration setting.
    Following RFC 7230, if the enabled_import_methods is empty,
    the header is not returned with the response.

    Change-Id: I3066da36a0fbb83fe492bddb193975e42ffc5084
    Closes-bug: #1748559
    (cherry picked from commit 3712dccfdb7ee30243e4efc09fcad1c3197bdb51)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 16.0.0.0rc2

This issue was fixed in the openstack/glance 16.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/glance 17.0.0.0b1

This issue was fixed in the openstack/glance 17.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.