[PATCH] SVN doesn't compile without LCMS

Bug #174854 reported by Maarten Maathuis
2
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Medium
Bryce Harrington

Bug Description

There are some missing ifdef's, please verify if the fix is the correct one. I only verified building and basic running of inkscape.

Revision history for this message
Maarten Maathuis (madman2003) wrote :
bbyak (buliabyak)
Changed in inkscape:
assignee: nobody → jon-joncruz
Revision history for this message
Maarten Maathuis (madman2003) wrote :
Download full text (3.9 KiB)

Still broken.

widgets/desktop-widget.cpp: In static member function ‘static void PrefWatcher::hook(EgeColorProfTracker*, gint, gint, PrefWatcher*)’:
widgets/desktop-widget.cpp:162: warning: dereferencing type-punned pointer will break strict-aliasing rules
widgets/desktop-widget.cpp:163: error: ‘colorprofile_set_display_per’ is not a member of ‘Inkscape’
widgets/desktop-widget.cpp:163: warning: unused variable ‘id’
widgets/desktop-widget.cpp: In member function ‘virtual void PrefWatcher::notifyAttributeChanged(Inkscape::XML::Node&, GQuark, Inkscape::Util::ptr_shared<char>, Inkscape::Util::ptr_shared<char>)’:
widgets/desktop-widget.cpp:210: error: ‘new_value’ was not declared in this scope
widgets/desktop-widget.cpp: At global scope:
widgets/desktop-widget.cpp:213: error: expected declaration before ‘}’ token
widgets/desktop-widget.cpp:85: warning: ‘void sp_desktop_widget_class_init(SPDesktopWidgetClass*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:86: warning: ‘void sp_desktop_widget_init(SPDesktopWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:87: warning: ‘void sp_desktop_widget_destroy(GtkObject*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:89: warning: ‘void sp_desktop_widget_size_allocate(GtkWidget*, GtkAllocation*)’ declared ‘static’ but never defined
        widgets/desktop-widget.cpp:90: warning: ‘void sp_desktop_widget_realize(GtkWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:92: warning: ‘gint sp_desktop_widget_event(GtkWidget*, GdkEvent*, SPDesktopWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:94: warning: ‘void sp_dtw_color_profile_event(EgeColorProfTracker*, SPDesktopWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:95: warning: ‘void cms_adjust_toggled(GtkWidget*, void*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:96: warning: ‘void cms_adjust_set_sensitive(SPDesktopWidget*, bool)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:97: warning: ‘void sp_desktop_widget_adjustment_value_changed(GtkAdjustment*, SPDesktopWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:98: warning: ‘void sp_desktop_widget_namedview_modified(SPObject*, guint, SPDesktopWidget*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:100: warning: ‘gdouble sp_dtw_zoom_value_to_display(gdouble)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:101: warning: ‘gdouble sp_dtw_zoom_display_to_value(gdouble)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:102: warning: ‘gint sp_dtw_zoom_input(GtkSpinButton*, gdouble*, void*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:103: warning: ‘bool sp_dtw_zoom_output(GtkSpinButton*, void*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:104: warning: ‘void sp_dtw_zoom_value_changed(GtkSpinButton*, void*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:105: warning: ‘void sp_dtw_zoom_populate_popup(GtkEntry*, GtkMenu*, void*)’ declared ‘static’ but never defined
widgets/desktop-widget.cpp:106: warning: ‘void sp_dtw_zoom_menu_handler(SPDes...

Read more...

vonHalenbach (lustik)
Changed in inkscape:
importance: Undecided → Medium
milestone: none → 0.46
status: New → Triaged
Revision history for this message
sironneaur (remy-sironneau) wrote :

Still broken for me too, on snapshot inkscape-16971.

Revision history for this message
Bryce Harrington (bryce) wrote :

Patch tested and committed for 0.46. Thanks!

Changed in inkscape:
assignee: jon-joncruz → bryceharrington
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.