undercloud installation fails "with Invalid query params: network"

[Sofer Athlan-Guyot]

Installation of master undercloud fails with this message:

2018-02-08 13:15:31,909 INFO: Network created openstack.network.v2.network.Network(provider:physical_network=ctlplane, ipv6_address_scope=None, revision_number=2, port_security_enabled=True, mtu=1500, id=75b050ee-87eb-4f24-ba22-4c8cd32f8112, router:external=False, availability_zone_hints=[], availability_zones=[], ipv4_address_scope=None, shared=False, project_id=3c685a63d73d4cd6804f7d3c5a452f25, status=ACTIVE, subnets=[], description=, tags=[], updated_at=2018-02-08T13:15:31Z, provider:segmentation_id=None, name=ctlplane, admin_state_up=True, created_at=2018-02-08T13:15:31Z, provider:network_type=flat)
2018-02-08 13:15:31,916 INFO: Network create/update failed Invalid query params: network
2018-02-08 13:15:31,916 DEBUG: An exception occurred
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 2309, in install
    _post_config(instack_env, upgrade)
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 1985, in _post_config
    network = _ensure_neutron_network(sdk)
  File "/usr/lib/python2.7/site-packages/instack_undercloud/undercloud.py", line 2038, in _ensure_neutron_network
    segments = list(sdk.network.segments(network=network.id))
  File "/usr/lib/python2.7/site-packages/openstack/resource.py", line 883, in list
    cls._query_mapping._validate(params, base_path=cls.base_path)
  File "/usr/lib/python2.7/site-packages/openstack/resource.py", line 252, in _validate
    extra_data=invalid_keys)
InvalidResourceQuery: Invalid query params: network
2018-02-08 13:15:31,924 ERROR:
#############################################################################
Undercloud install failed.

Reason: Invalid query params: network

See the previous output for details about what went wrong. The full install
log can be found at /home/centos/.instack/install-undercloud.log.

#############################################################################

Not sure why it's not caught by ci.

instack-undercloud-8.2.1-0.20180208061905.46a5df2.el7.centos.noarch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/542204

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

I guess ci doesn't catch it because network exist already somehow ?

https://github.com/openstack/instack-undercloud/blob/master/instack_undercloud/undercloud.py#L2029..L2035

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/542204
Committed: https://git.openstack.org/cgit/openstack/instack-undercloud/commit/?id=8dc0d289a7366f4eae723fb0b6422131054d6025
Submitter: Zuul
Branch: master

commit 8dc0d289a7366f4eae723fb0b6422131054d6025
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Feb 8 15:03:03 2018 +0100

    Fix typo that can prevent undercloud installation.

    The interface to sdk.network.segments use network_id, not network[1].

    Closes-Bug: #1748199

    [1] https://github.com/openstack/python-openstacksdk/blob/master/openstack/network/v2/segment.py#L30..L34

    Change-Id: Ibda590103ed8b02a1ce05e285a3d9d9ea2e2ff7f

[wes hayutin (weshayutin)]

This was just caught in CI in the promotion pipeline
https://logs.rdoproject.org/openstack-periodic/periodic-tripleo-centos-7-master-containers-build/c93c75b/undercloud/home/jenkins/undercloud_install.log.txt.gz

Sofer I think you must be trying to deploy w/ https://trunk.rdoproject.org/centos7-master/ current or consistent and usually you'll have bad results w/ that.

Try to use current-tripleo that is the first CI verified repo.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Hum, we switch repo to delorean current to all tripleo project some time ago there 21138dacfc77d09201939f3a30eb9a86f50374a2 and 5c4aaf3d6f1b92077a84ee335c87e7ff612a4b69 for pike->master. Well all release files. If you think that's wrong that another round of discussion should happen.

[wes hayutin (weshayutin)]

This patch is not yet in the master or queens build, reopening until the package is available

<weshay|ruck> consistent is at https://github.com/openstack/instack-undercloud/commits/master https://github.com/openstack/instack-undercloud/commit/46a5df2625b36e3b42b33a4b9f439bab0a87b1c7 and we need https://github.com/openstack/instack-undercloud/commit/8dc0d289a7366f4eae723fb0b6422131054d6025
<jpena> weshay|ruck: we have seen some projects started branching stable/queens, so we're bootstrapping the queens repository
<jpena> Once it is complete and consistent, we should start using that repo for promotions
<weshay|ruck> jpena, hrm..
<weshay|ruck> jpena, do we want to block a build on that?
<jpena> otherwise we're at risk of including rocky commits
<weshay|ruck> jpena, hrm.. k
<weshay|ruck> jpena, we'll need that commit for queens for sure
<weshay|ruck> instack-undercloud will not install w/o it

[Alan Pevec (apevec)]

https://trunk.rdoproject.org/centos7-master/consistent/instack-undercloud-8.2.1-0.20180208205546.8dc0d28.el7.centos.noarch.rpm

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/instack-undercloud 8.3.0 release.