fencing can fail if IHA is not configured

[Michele Baldessari]

If we configure fencing but not IHA we can potentially get this error:

"Error: Evaluation Error: Error while evaluating a Function Call, Could not find data item compute_instanceha_short_node_names in any Hiera
data file and no default supplied at /etc/puppet/modules/tripleo/manifests/fencing.pp:61:13 on node controller-0.localdomain"

This is because we unconditionally look up a hiera key that might not always exist

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/541240

[Michele Baldessari (michele)]

Brought up by Marian via https://bugzilla.redhat.com/show_bug.cgi?id=1542424

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541240
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=ee7be9b7ad8157030911570783ecbe28b79fa107
Submitter: Zuul
Branch: master

commit ee7be9b7ad8157030911570783ecbe28b79fa107
Author: Michele Baldessari <email address hidden>
Date: Tue Feb 6 11:44:12 2018 +0100

    Do not fail fencing configuration when instanceha is disabled

    Right now we fail like this if fencing is enabled but instanceha is not:
    "Error: Evaluation Error: Error while evaluating a Function Call, Could not find data item compute_instanceha_short_node_names in any Hiera
    data file and no default supplied at /etc/puppet/modules/tripleo/manifests/fencing.pp:61:13 on node controller-0.localdomain"

    Change-Id: I36691997bffc56cb4fe17b2f762e4d44d71dfe50
    Closes-Bug: #1747643

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 8.3.0 release.