schema: duplicate block makes original invisble

[Nicholas Savenlid]

1: mark some objects
2: duplicate block
once you start to move your duplicated block the original becomes invisible so it appears like a move operation

3: put your copy down, and the original becomes visible again

Application: kicad
Version: (2018-02-02 revision dc66b73a2)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

@Nicholas, we're tracking this in 1740138 so I reported your findings there.

[Seth Hillbrand (sethh)]

@Jeff- The block operation is selecting/keeping a list of objects before operating on them. This looks like just a display issue, XORing when we shouldn't. I've removed it from the block operation bug as that will be a post-5 feature whereas this could easily make it into 5.0

[Seth Hillbrand (sethh)]

I'm not seeing this on Linux. In fact, move and duplicate block both show both copies for me right now.

Anyone else observing this issue or is it a Windows thing?

[Jeff Young (jeyjey)]

@Seth, are you in pcbnew instead of eeschema? The original copy has always disappeared for me when in eeschema.

[Seth Hillbrand (sethh)]

@Jeff- That's odd. Definitely not seeing this in linux. Are you using linux or Mac? Maybe it's a graphics card issue?

[Jeff Young (jeyjey)]

OSX (High Sierra)

I'm currently working on some more performance fixes, but I might take a look at it in a few days....

[Wayne Stambaugh (stambaughw)]

I just confirmed this on windows 7. My guess is that the XOR operation is being performed in the same way that a block move would be to erase the original block objects. This should not happen at the current position on a block duplicate operation.

[Jeff Young (jeyjey)]

Interestingly, move has the opposite error: both are visible until you drop the moved item.

[Nick Østergaard (nickoe)]

This is a but strange. Never noticed that "Duplicate block" option in the context menu. I have always used the shift+<now drag the block> and move cursor and then place method.

Using the shift modifier for the block selection keeps both shown as you would expect, but indeed using the context menu does not.

Application: kicad
Version: (2018-02-12 revision ed127e866)-makepkg, release build
Libraries:
    wxWidgets 3.0.3
    libcurl/7.54.1 OpenSSL/1.0.2l zlib/1.2.11 libssh2/1.8.0 nghttp2/1.23.1 librtmp/2.3
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.3 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.60.0
    Curl: 7.54.1
    Compiler: GCC 7.1.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

@jeff - Do you still see this issue?

[Jeff Young (jeyjey)]

I'm still seeing the move issue, but not the duplicate one.

[Jeff Young (jeyjey)]

Hooray for the GAL canvas!

[KiCad Janitor (kicad-janitor)]

Fixed in revision 7216eda202d89423ab6c89406e098419605925dd
https://git.launchpad.net/kicad/patch/?id=7216eda202d89423ab6c89406e098419605925dd