tripleo-common: ImportError: No module named keystoneclient

[James Slagle]

At some point on 2018-02-02, all tripleo-common tox python jobs started failing with:

2018-02-02 15:05:50.952070 | ubuntu-xenial | Failed to import test module: tripleo_common.tests.actions.test_templates
2018-02-02 15:05:50.952095 | ubuntu-xenial | Traceback (most recent call last):
2018-02-02 15:05:50.952184 | ubuntu-xenial | File "/home/zuul/src/git.openstack.org/openstack/tripleo-common/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 456, in _find_test_path
2018-02-02 15:05:50.952215 | ubuntu-xenial | module = self._get_module_from_name(name)
2018-02-02 15:05:50.952308 | ubuntu-xenial | File "/home/zuul/src/git.openstack.org/openstack/tripleo-common/.tox/py27/local/lib/python2.7/site-packages/unittest2/loader.py", line 395, in _get_module_from_name
2018-02-02 15:05:50.952330 | ubuntu-xenial | __import__(name)
2018-02-02 15:05:50.952378 | ubuntu-xenial | File "tripleo_common/tests/actions/test_templates.py", line 22, in <module>
2018-02-02 15:05:50.952410 | ubuntu-xenial | from tripleo_common.actions import templates
2018-02-02 15:05:50.952452 | ubuntu-xenial | File "tripleo_common/actions/templates.py", line 29, in <module>
2018-02-02 15:05:50.952481 | ubuntu-xenial | from tripleo_common.actions import base
2018-02-02 15:05:50.952520 | ubuntu-xenial | File "tripleo_common/actions/base.py", line 30, in <module>
2018-02-02 15:05:50.952560 | ubuntu-xenial | from tripleo_common.utils import keystone as keystone_utils
2018-02-02 15:05:50.952600 | ubuntu-xenial | File "tripleo_common/utils/keystone.py", line 22, in <module>
2018-02-02 15:05:50.952642 | ubuntu-xenial | from keystoneclient import service_catalog as ks_service_catalog
2018-02-02 15:05:50.952672 | ubuntu-xenial | ImportError: No module named keystoneclient

we don't have python-keystoneclient in requirements.txt, though we probably should. guess we were implicitly getting it from somewhere else previously and something must have changed to where it's now explicitly required.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/540601

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/540601
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1c760d570a58b69a94e58d147a863f037720189c
Submitter: Zuul
Branch: master

commit 1c760d570a58b69a94e58d147a863f037720189c
Author: James Slagle <email address hidden>
Date: Sat Feb 3 11:16:39 2018 -0500

    Add keystoneclient to requirements.txt

    At some point on 2018-02-02, all tripleo-common tox python jobs started
    failing with:

    2018-02-02 15:05:50.952672 | ubuntu-xenial | ImportError: No module
    named keystoneclient

    We did't have python-keystoneclient in requirements.txt, though we
    probably should. We must have been implicitly getting it from somewhere
    else previously and something must have changed to where it's now
    explicitly required.

    Change-Id: I272292f2f411d1195e5986f0f6a24b379fbf2b6e
    Closes-Bug: #1747160

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.5.0 release.