CloseModalXButton submits the form

Bug #1746517 reported by Jiri Tomasek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Jiri Tomasek

Bug Description

CloseModalXButton defines html button, which is type="submit" by default. Clicking such button can cause submission of a form.

Tags: ui
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/539533

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/539533
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=e7467b28357bb2437217bfadc73cd7fcde284385
Submitter: Zuul
Branch: master

commit e7467b28357bb2437217bfadc73cd7fcde284385
Author: Jiri Tomasek <email address hidden>
Date: Wed Jan 31 14:37:16 2018 +0100

    Set CloseModalXButton to use button type

    CloseModalXButton needs to use button type="button" to prevent submitting
    form when clicked

    Closes-Bug: 1746517
    Change-Id: Ic503bdd898a1732fca8922a7eb9a54be943ee29d

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ui 8.3.0

This issue was fixed in the openstack/tripleo-ui 8.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.