Fix unittest issues related to repository split

Bug #1746451 reported by Krzysztof Klimonda
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Released
High
Krzysztof Klimonda
OpenContrail
New
Undecided
Unassigned

Bug Description

We have a number of unittest build failures related to the repository split - this bug will be used to track all fixes.

Tags: ci
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39346
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39344
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39346
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39345
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39344
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39390
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39346
Committed: http://github.com/Juniper/contrail-common/commit/c0c3ee494aa164e6764ca8827897c19ac0001fa4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c0c3ee494aa164e6764ca8827897c19ac0001fa4
Author: Krzysztof Klimonda <email address hidden>
Date: Wed Jan 31 09:50:43 2018 +0100

Remove #ifndef WIN32 from factory.h code

This code is platform agnostic, and linux version was missing macros
used by tests. Remove #ifndef WIN32 and keep single code paths for
Windows and POSIX platforms.

Partial-Bug: #1746451
Change-Id: I9901ff28cbed5ea2720fd6e05e14b8dded29939c

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39390
Committed: http://github.com/Juniper/contrail-common/commit/48ad9fbce69de122137637319e6bbf1edb9cd44f
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 48ad9fbce69de122137637319e6bbf1edb9cd44f
Author: Krzysztof Klimonda <email address hidden>
Date: Thu Feb 1 13:09:29 2018 +0100

Link sandesh tests against boost_thread library

sandesh tests have multiple build failures due to linking errors, e.g.:
```
undefined reference to `vtable for boost::detail::thread_data_base'
```

Add boost_thread to the library list.

Partial-Bug: #1746451
Change-Id: Ie0217f481c21ad5cf5e5564bf08f1034c98dbf1a

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39483
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39486
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39344
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39483
Committed: http://github.com/Juniper/contrail-common/commit/3dbaea81bd1ad38f74ea4a32f559621a0711e1c1
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 3dbaea81bd1ad38f74ea4a32f559621a0711e1c1
Author: Krzysztof Klimonda <email address hidden>
Date: Tue Feb 6 08:04:06 2018 +0100

Remove unused #includes, fixing test compilation

Some #includes are no longer used, and were not moved from
contrail-controller to contrail-common along with the tests, breaking
the build.

Partial-Bug: #1746451
Change-Id: Ia1ed8cae723661d7dd97a1d362f5cacb36ff9b7d

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39344
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39787
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39787
Committed: http://github.com/Juniper/contrail-build/commit/dc0012ec479e930867c718cb1ed8e9f1c2318164
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit dc0012ec479e930867c718cb1ed8e9f1c2318164
Author: Krzysztof Klimonda <email address hidden>
Date: Thu Feb 15 13:04:28 2018 +0100

Don't build Python from sources

We don't support any Linux distribution that does not come with Python
2.7.x so we can just reuse system binaries.

Also, use virtualenv installed from packages - our images have
virtualenv baked in already.

Partial-Bug: #1746451
Change-Id: I9d7a74949fd72c2bb86b2e8d1ceb6e21ebecc8d1

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39345
Committed: http://github.com/Juniper/contrail-common/commit/22c4ef25bb98de42f6fab943ab2f8d2d1be994ac
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit 22c4ef25bb98de42f6fab943ab2f8d2d1be994ac
Author: Krzysztof Klimonda <email address hidden>
Date: Wed Jan 31 09:27:24 2018 +0100

Add address_test unit test

address.cc has been moved to contrail-common, and this follow-up commit
moves its tests so that they compile and run.

Partial-Bug: #1746451
Change-Id: I1083264b53fa824a6eb3c6ed9ec5c332fe36fa7e
Depends-On: I0608e44c64bb2204013dc272da3a0d1253354f80

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39344
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39344
Committed: http://github.com/Juniper/contrail-controller/commit/18ef5e37e1902eeb7ecf73a4db412d1bd29aca3b
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit 18ef5e37e1902eeb7ecf73a4db412d1bd29aca3b
Author: Krzysztof Klimonda <email address hidden>
Date: Wed Jan 31 09:24:16 2018 +0100

Remove address_test from contrail-controller repository

address.cc has been moved to contrail-common, and address_test is no
longer building - move it also to contrail-common to fix tests.

Partial-Bug: #1746451
Change-Id: I0608e44c64bb2204013dc272da3a0d1253354f80

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39486
Committed: http://github.com/Juniper/contrail-controller/commit/9a27ce685d46ca66534e72d9929a8c94c65e54fc
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 9a27ce685d46ca66534e72d9929a8c94c65e54fc
Author: Krzysztof Klimonda <email address hidden>
Date: Tue Feb 6 09:20:54 2018 +0100

Update some SCons targets to mirror repository split

"controller/test" target is called for `scons test` and fails to build
do to its dependencies moving to contrail-common. Update targets to
match this move.

Partial-Bug: #1746451
Change-Id: Ie572f62b27da074e1ca6331683591539c1474013

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39903
Submitter: Krzysztof Klimonda (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39903
Committed: http://github.com/Juniper/contrail-common/commit/cdc277d3c215a9a1108c889b3ef9e03dd5b1a0de
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit cdc277d3c215a9a1108c889b3ef9e03dd5b1a0de
Author: Krzysztof Klimonda <email address hidden>
Date: Tue Feb 20 11:08:37 2018 +0100

Add bottle to the pysandesh requirements list

We're seeing UT failures ending with:

ImportError: No module named bottle

Add bottle to the list of pysandesh dependencies so it gets installed.

Partial-Bug: #1746451
Change-Id: Icc228344923219d0dff5e798ffe54c7cb672e445

Jeba Paulaiyan (jebap)
tags: added: ci
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.