dlrn_api; containers-push.yml fails to tag containers passed for rdo phase 2 because tripleo-common was updated after tripleo promotion

[wes hayutin]

failed: [localhost] (item=keepalived) => {"failed": true, "item": "keepalived", "msg": "Error pulling trunk.registry.rdoproject.org/master/centos-binary-keepalived - code: None message: Error: image master/centos-binary-keepalived:17a57d99b10f5872520e1a395214f80c9cfd1a65_c30c070f not found"}

changed: [localhost] => (item=zaqar)
failed: [localhost] (item=tempest) => {"failed": true, "item": "tempest", "msg": "Error pulling trunk.registry.rdoproject.org/master/centos-binary-tempest - code: None message: Error: image master/centos-binary-tempest:17a57d99b10f5872520e1a395214f80c9cfd1a65_c30c070f not found"}
changed: [localhost] => (item=rsyslog-base)

Timeline:
TripleO promoted on 1/23 built and pushed containers
RDO P1 promoted 1/23
RDO P2 trying to promote on 1/28

tripleo-common was updated between 1/23 and 1/28 with two new containers.

https://github.com/openstack/tripleo-common/commit/b78d7acb892e8dfbd44770a53e4b39f622bc6aff#diff-eef2b725037682ccef9813957e53e810
https://github.com/openstack/tripleo-common/commit/c28e8cbb8a96035344cb5107020a35668fa0adda#diff-eef2b725037682ccef9813957e53e810

RDO Phase 2 is trying to promote two containers that have never been built for the hash that is being promoted, and it's failing as a result.

Fix:

Update the containers-push.yml [1] to get the tripleo-common version that was available at the time of the promotion [2] and use that commit when pulling the overcloud_containers.yaml.j2 file.

[1] https://github.com/rdo-infra/ci-config/blob/master/ci-scripts/container-push/container-push.yml
[2] https://trunk.rdoproject.org/centos7-master/current-tripleo-rdo/openstack-tripleo-common-8.3.1-0.20180123050217.f69ea9e.el7.centos.noarch.rpm

[John Trowbridge (trown)]

being addressed by https://review.rdoproject.org/r/11633