Placing hold should not be possible without an entered barcode

[Chris Sharp]

When placing a hold for myself as a logged-in staff member, when I arrive at the hold placement screen (eg/opac/place_hold), the "Place hold for patron by barcode:" radio button is the default. When I overlooked this and clicked Submit, I was taken to the hold result screen and saw:

Hold could not be placed.
Reason: The attempt to query to the DB failed

The error message is this:

2018-01-29 10:18:38 brick03-head open-ils.circ: [ERR :10119:CStoreEditor.pm:139:151722510465211434] editor[0|2554624] request error open-ils.cstore.direct.actor.user.retrieve : {"pid":13905,"desc":"Someone attempted to retrieve a user from the system and the user was not found","textcode":"ACTOR_USER_NOT_FOUND","stacktrace":"/usr/local/share/perl/5.22.1/OpenILS/Application/Actor.pm:3352 /usr/local/share/perl/5.22.1/OpenSRF/Application.pm:628 /usr/share/perl5/Error.pm:416","ilsevent":"1002","servertime":"Mon Jan 29 15:18:38 2018"} : Exception: OpenSRF::DomainObject::oilsMethodException 2018-01-29T15:18:38 OpenILS::Utils::CStoreEditor /usr/local/share/perl/5.22.1/OpenILS/Utils/CStoreEditor.pm:465 <500> Severe query error -- see error log for more details

It took me a few minutes to realize what I had done.

There should be some sort of logic here to handle the possibility that the user did not enter a barcode with "Place hold for patron by barcode:" selected. Ideally something that disables the Submit button until valid data is present.

Evergreen 3.0.2
OpenSRF 3.0.0
PostgreSQL 9.5
Ubuntu 16.04 LTS

[Andrea Neiman (aneiman)]

3.9 BOOPAC sidesteps this buy not showing the radio selector at all when logged in to the OPAC as a staff member. The only option is to place the hold for the logged in account.