Unable to log into web client on iOS

Bug #1746020 reported by Tim Spindler
24
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

I was testing Evergreen 3.0 web client with my iPhone and no login prompt appears. A colleague checked with an Android and is able to login. The web client login does work on with my iPhone in 2.12. I have tested this with Chrome and Firefox. The iphone model is the iphone 7 plus.

Revision history for this message
Scott Thomas (scott-thomas-9) wrote :

Same at 3.03 and iPhone 8 Plus iOS 11.2.5.

Revision history for this message
Anna Goben (agoben) wrote :

This was what went out to my libraries about this earlier this month:

"Supported Browsers
-Chrome on Windows, Mac OS, Linux, and Android (small screen support isn't ideal but it does work)
-Firefox on Windows, Mac OS, and Linux

Safari (Mac OS or iOS) and Edge (Windows 10) used to but do NOT currently work. They may work with the client again after an update (these browsers are missing some features used by the web client); Internet Explorer will never work. Because all browsers on iOS actually use Safari behind the scenes, Chrome on iOS doesn't currently work either." -Jason Boyer

Revision history for this message
Tim Spindler (tspindler-cwmars) wrote :

Here are my details on my phone IOS 11.2.2 and Evergreen 3.03.

Changed in evergreen:
status: New → Confirmed
importance: Undecided → Medium
status: Confirmed → Triaged
Changed in evergreen:
status: Triaged → Won't Fix
Revision history for this message
Galen Charlton (gmc) wrote :

Upon a quick test in Evergreen master with Safari 9.1.2, I note that the specific reason why the login prompt isn't being rendered has to do with our use of BroadcastChannel, which Safari doesn't support. The following patch works around the issue:

diff --git a/Open-ILS/web/js/ui/default/staff/services/auth.js b/Open-ILS/web/js/ui/default/staff/services/auth.js
index ec83005..b93b6b8 100644
--- a/Open-ILS/web/js/ui/default/staff/services/auth.js
+++ b/Open-ILS/web/js/ui/default/staff/services/auth.js
@@ -312,7 +312,7 @@ function($q , $timeout , $rootScope , $window , $location , egNet , egHatch) {

     service.logout = function(broadcast) {

- if (broadcast) {
+ if (broadcast && service.authChannel.postMessage) {
             // Tell the other tabs to shut it all down.
             service.authChannel.postMessage({action : 'logout'});
         }

Revision history for this message
Galen Charlton (gmc) wrote :

That said, the policy issue — whether to formally support Safari and derivatives in the first place — remains open.

Revision history for this message
Kathy Lussier (klussier) wrote :

Since the policy issue remains open, I'm going to set this back from Won't Fixed to Triage until such time that was have an opportunity to clarify which browsers have formal support.

My recollection from initial discussions was that we would support desktop Firefox and Chrome, but now that we are rolling the client out into production environments, it's probably a good time to either reaffirm that policy or make adjustments.

Changed in evergreen:
status: Won't Fix → Triaged
summary: - Iphone
+ Unable to log into web client on iOS
Revision history for this message
Tim Spindler (tspindler-cwmars) wrote :

I don't know if this is related but I can login with my iMac on our instance of 3.03

iMac (Retina 5K, 27-inch)
Sierra IOS 10.13.2

Revision history for this message
Tim Spindler (tspindler-cwmars) wrote :

Add one more thing on my iMac, I logged in successfully with Chrome and Firefox.

Revision history for this message
Kathy Lussier (klussier) wrote :

Hi Tim,

From my understanding of the discussion to date, the reason it doesn't work on iOS is because Safari is the underlying browser for all browsers in iOS, even if you don't choose to use Safari. This isn't the case if you use Chrome or Firefox on the iMac.

Revision history for this message
Kathy Lussier (klussier) wrote :

I've put Galen's patch into a git branch:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/kmlussier/lp1746020-broadcast-channel-workaround

I still haven't tested it, but I plan to find somebody who can test it this afternoon.

Revision history for this message
Jason Stephenson (jstephenson) wrote :

I'd like to point out that just because Galen's patch allows one to login with a browser on iOS, that does not mean that all iOS issues are resolved by this patch. There very well may be other issues that come up once you're logged in.

Revision history for this message
Kathy Lussier (klussier) wrote :

True, but it's a bit difficult to find out what those other issues might be if you can't log in. I know there is a larger discussion that needs to be had, but I don't see any harm in getting this one particular issue addressed.

Revision history for this message
Jason Boyer (jboyer) wrote :

I almost forgot, we've been running this for a few days, it does what it says and hurts nothing else.

Signage:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1746020-broadcast-channel-workaround-signoff

tags: added: pullrequest signedoff
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.0.4
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_0. Thanks, folks!

Changed in evergreen:
status: Triaged → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.