Add unit tests and pep8
Bug #1745966 reported by
Liam Young
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| vault-charm |
Fix Released
|
Medium
|
Liam Young | ||
Bug Description
It would be useful if the charm had support for running some common tasks though tox, such as:
* pep8
* charm build
* unit tests
* charm proof tests
Related branches
~gnuoy/vault-charm:fix-lint
Merged
into
~vault-charmers/vault-charm/+git/vault-charm:master
at
revision ea847b1f96eeaab847b285874daf793f517708e1
- Stuart Bishop (community): Approve
-
Diff: 95 lines (+21/-10)2 files modifiedfiles/nagios/check_vault_version.py (+2/-3)
reactive/vault.py (+19/-7)
~gnuoy/vault-charm:testing
Merged
into
~vault-charmers/vault-charm/+git/vault-charm:master
at
revision dbdf72016c7a2c32c2249f00c82be854151a8829
- Vault charmers: Pending requested
-
Diff: 92 lines (+57/-0)6 files modified.gitignore (+4/-0)
.stestr.conf (+3/-0)
requirements.txt (+2/-0)
test-requirements.txt (+4/-0)
tox.ini (+44/-0)
unit_tests/__init__.py (+0/-0)
| description: | updated |
| Changed in vault-charm: | |
| assignee: | nobody → Liam Young (gnuoy) |
| importance: | Undecided → Medium |
| status: | New → Confirmed |
| Changed in vault-charm: | |
| status: | Confirmed → In Progress |
| Changed in vault-charm: | |
| status: | In Progress → Fix Committed |
| Changed in vault-charm: | |
| milestone: | none → 19.04 |
| Changed in vault-charm: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
