circ history - change user setting for feature to a single boolean setting

[Josh Stompro]

EG 3.0 , There are currently two user setting preferences for enabling the circ history feature.

history.circ.retention_age and history.circ.retention_start

These settings are currently evaluated as being true if they have any value, even though one has a date type and one has an inteval type.

For simplicity those preferences should be replaced with one boolean preference. This would also make it easier to integrate that setting into the patron registration screen.

history.circ.retention_start gets set to the current date when enabled by customers, but that date doesn't serve any purpose with the current methods. history.circ.retention_age isn't used to control the bounds of how much history is kept any more.

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/sql/Pg/090.schema.action.sql#l1562 - Where those values are evaluated when storing circ history.

Josh

[Josh Stompro (u-launchpad-stompro-org)]

Should we switch to a new preference completely, or switch history.circ.retention_start to being a boolean user_setting to fix this?

Maybe switching over to something like "history.circ.retention_enabled" would make things clearer?

Josh