puppet-tripleo interface names should be downcase for lookupvar

[Dan Radez]

According to:
https://tickets.puppetlabs.com/browse/FACT-777
factnames are downcased to avoid facts becoming Types if they have an uppercase first character.

network interface names can have uppercase characters in them.
[root@overcloud-controller-0 ~]# puppet facts | grep enP2p1s0f1
    "interfaces": "br_ex,enP2p1s0f1,enP2p1s0f2,enP2p1s0f3,enP2p1s0f4,enP2p1s0f5,lo,ovs_system",
but when puppet pulls in the facts they get downcased:
[root@overcloud-controller-0 ~]# puppet facts | grep enp2p1s0f1
    "network_enp2p1s0f1": "192.0.2.0",
    "ipaddress_enp2p1s0f1": "192.0.2.6",
    "macaddress_enp2p1s0f1": "1c:1b:0d:98:97:2e",
    "netmask_enp2p1s0f1": "255.255.255.0",
    "mtu_enp2p1s0f1": 1500,
    "netmask6_enp2p1s0f1": "ffff:ffff:ffff:ffff:0000:0000:0000:0000",

In https://github.com/openstack/puppet-tripleo/blob/master/lib/puppet/parser/functions/interface_for_ip.rb
the interface name should be downcased to make sure interface names match the factnames.

This was tested in Pike, though the issue exists in all versions.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/537960
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=c62bb666679f35fb8b7305ac94620a8f99a5b322
Submitter: Zuul
Branch: master

commit c62bb666679f35fb8b7305ac94620a8f99a5b322
Author: Dan Radez <email address hidden>
Date: Thu Jan 25 11:27:58 2018 -0500

    Ensure interface names are downcased

    https://tickets.puppetlabs.com/browse/FACT-777
    Puppet downcases fact names so they names don't become Types
    Interfaces can have Uppercase letters in them.

    Closes-Bug: #1745448

    Change-Id: I03fd5c103f4b4d4c90770f4d8aa26ae8eeeecdcd

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 9.0.0 release.