Version 2.8.22 of construct has introduced a change to the core exception handling. The FieldError exception is no longer supported. As ironic-inspector was handling this exception explicitly it results in the following ironic-inspector test failures.
ironic_inspector.test.unit.test_plugins_lldp_basic.TestLLDPBasicProcessingHook.test_invalid_ip
----------------------------------------------------------------------------------------------
Captured traceback:
~~~~~~~~~~~~~~~~~~~
Traceback (most recent call last):
File "/home/bfournie/workspace/ironic-inspector/.tox/py3/lib/python2.7/site-packages/mock/mock.py", line 1305, in patched
return func(*args, **keywargs)
File "ironic_inspector/test/unit/test_plugins_lldp_basic.py", line 288, in test_invalid_ip
self.hook.before_update(self.data, self.node_info)
File "ironic_inspector/plugins/lldp_basic.py", line 82, in before_update
nv = self._parse_lldp_tlvs(tlvs, node_info)
File "ironic_inspector/plugins/lldp_basic.py", line 56, in _parse_lldp_tlvs
if parser.parse_tlv(tlv_type, data):
File "ironic_inspector/common/lldp_parsers.py", line 158, in parse_tlv
except (core.RangeError, core.FieldError, core.MappingError,
AttributeError: 'module' object has no attribute 'FieldError'
The explicit exception handling on parsing the lldp data is not required and this should be replaced by a general exception handler.
Fix proposed to branch: master
Review: https:/