As stackalytics calculate contributions based on the commit authorDate, for some commits wrong informations about the employer information of coauthor will be saved in the storage.
There is a patch in Trove been merged recently:
https://review.openstack.org/#/c/509795
It was started in Oct 2017, but actually the primary work was done at the last update at Jan 19, 2018. When the commit is merged, my contribution were added to my former employer as the authorDate is in Oct 2017. The company informations should be corrected to my current employer.
record informations of the coauthors:
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=zhaochao1984&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Zhao Chao</a>",
"author_name": "Zhao Chao",
"blueprint_id": [],
"blueprint_id_count": 0,
"branches": "master",
"bug_id_count": 0,
"change_id": [
"Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b"
],
"coauthor": [
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=zhaochao1984&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Zhao Chao</a>",
"author_name": "Zhao Chao",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Eayun&module=trove\">Eayun</a>",
"company_name": "Eayun",
"date": 1507214060,
"user_id": "zhaochao1984"
},
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=ldbragst&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Lance Bragstad</a>",
"author_name": "Lance Bragstad",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Huawei&module=trove\">Huawei</a>",
"company_name": "Huawei",
"date": 1507214060,
"user_id": "ldbragst"
}
],
"commit_date": 1507214060,
"commit_date_str": "05 Oct 2017 14:34:20 UTC",
"commit_id": "e78b42237bf56d10d35f99d01ed41775a50d7e8c",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Eayun&module=trove\">Eayun</a>",
"company_name": "Eayun",
"correction_comment": "",
"date": 1516486003,
"date_str": "20 Jan 2018 22:06:43 UTC",
"files_changed": 16,
"lines_added": 1230,
"lines_deleted": 190,
"loc": 1420,
"message": "The DocumentedRuleDefault class has advantages over the RuleDefault class because it allows project developers the opportunity to describe how policies map to actual APIs. This makes things a lot easier for operators trying to understand policies for a given project, and doesn't require them to dig in the code to figure out what they protect.\nPolices are also splitted into small files for easier maintainance.\nThis is part of an effort to move policy and documentation of policy into code, treating it like configuration.\nbp policy-and-docs-in-code Co-Authored-By: Zhao Chao <zhaochao1984@gmail.​com>\nChange-Id: <a href=\"https://review.openstack.org/#/q/Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b\" class=\"ext_link\">Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b</a>",
"module": "trove",
"module_link": "<a href=\"/?user_id=&metric=commits&module=trove&project_type=openstack&release=queens&company=\">trove</a>",
"primary_key": "<email address hidden>",
"record_id": 5842368,
"record_type": "commit",
"release": "queens",
"subject": "Use DocumentedRuleDefault instead of RuleDefault",
"user_id": "zhaochao1984",
"week": 2506
}
and
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=ldbragst&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Lance Bragstad</a>",
"author_name": "Lance Bragstad",
"blueprint_id": [],
"blueprint_id_count": 0,
"branches": "master",
"bug_id_count": 0,
"change_id": [
"Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b"
],
"coauthor": [
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=zhaochao1984&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Zhao Chao</a>",
"author_name": "Zhao Chao",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Eayun&module=trove\">Eayun</a>",
"company_name": "Eayun",
"date": 1507214060,
"user_id": "zhaochao1984"
},
{
"author_email": "<email address hidden>",
"author_link": "<a href=\"/?user_id=ldbragst&project_type=openstack&release=queens&metric=commits&company=&module=trove\">Lance Bragstad</a>",
"author_name": "Lance Bragstad",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Huawei&module=trove\">Huawei</a>",
"company_name": "Huawei",
"date": 1507214060,
"user_id": "ldbragst"
}
],
"commit_date": 1507214060,
"commit_date_str": "05 Oct 2017 14:34:20 UTC",
"commit_id": "e78b42237bf56d10d35f99d01ed41775a50d7e8c",
"company_link": "<a href=\"/?user_id=&project_type=openstack&release=queens&metric=commits&company=Huawei&module=trove\">Huawei</a>",
"company_name": "Huawei",
"correction_comment": "",
"date": 1516486003,
"date_str": "20 Jan 2018 22:06:43 UTC",
"files_changed": 16,
"lines_added": 1230,
"lines_deleted": 190,
"loc": 1420,
"message": "The DocumentedRuleDefault class has advantages over the RuleDefault class because it allows project developers the opportunity to describe how policies map to actual APIs. This makes things a lot easier for operators trying to understand policies for a given project, and doesn't require them to dig in the code to figure out what they protect.\nPolices are also splitted into small files for easier maintainance.\nThis is part of an effort to move policy and documentation of policy into code, treating it like configuration.\nbp policy-and-docs-in-code Co-Authored-By: Zhao Chao <zhaochao1984@gmail.​com>\nChange-Id: <a href=\"https://review.openstack.org/#/q/Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b\" class=\"ext_link\">Ifcdbccae7350ec69ad7d92197b9bfca8aeb8352b</a>",
"module": "trove",
"module_link": "<a href=\"/?user_id=&metric=commits&module=trove&project_type=openstack&release=queens&company=\">trove</a>",
"primary_key": "<email address hidden>",
"record_id": 5842369,
"record_type": "commit",
"release": "queens",
"subject": "Use DocumentedRuleDefault instead of RuleDefault",
"user_id": "ldbragst",
"week": 2506
}
Reviewed: https:/ /review. openstack. org/536117 /git.openstack. org/cgit/ openstack/ stackalytics/ commit/ ?id=8c7c848c708 32687b61fc0074f 0b4ac85f1b6e26
Committed: https:/
Submitter: Zuul
Branch: master
commit 8c7c848c7083268 7b61fc0074f0b4a c85f1b6e26
Author: Zhao Chao <email address hidden>
Date: Sun Jan 21 20:44:56 2018 +0800
Fix coauther company info for review 509795.
Stackalytics calculate contributions based on commit authordate, this /review. openstack. org/#/c/ 509795
causes the commit in:
https:/
adding wrong contribution to the former employer of the coauthor.
This patch fixes the problem by adding a correction to correct company
infos of the coauthor (the date information of the coauthor is also
corrected to the commitdate).
Closes-Bug: #1744557
Change-Id: Id018ca6a9c3fd0 ee8702723c7e340 54dbc6309c4
Signed-off-by: Zhao Chao <email address hidden>