Create from image with cloning fails with not enough space

[Mohammed Naser]

At the moment, when creating a new image, the check for local disk happens, even if the backend can clone volumes directly. This will result in failures to create volumes if there is not enough disk space, even though that space is not used.

[Eric Harney (eharney)]

https://review.openstack.org/#/c/535914/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/535914
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=f62f8abad17d1c287d48ea273ea4c4fe7f536d07
Submitter: Zuul
Branch: master

commit f62f8abad17d1c287d48ea273ea4c4fe7f536d07
Author: Mohammed Naser <email address hidden>
Date: Fri Jan 19 11:45:41 2018 -0800

    Move disk space check to run when needed

    At the moment, the check for disk space when booting from an image
    currently happens regardless if the backend supports cloning or not.

    This means that even if a backend can clone the image directly, the
    control plane must have enough disk to download the entire image
    which can be unreasonable in backend such as RBD.

    This patch moves the code which checks for enough disk space to be
    in the same function that effectively downloads the image, ensuring
    that it only runs when an image has to be downloaded and avoiding
    the check if the backend successfully cloned the image.

    Closes-Bug: #1744383
    Change-Id: Ibfd6f40e8b8ab88d4ec76e9ac27617a0f97b6c29

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/536529

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536529
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=0e57f89b8b0e3ed39c7fe59ee9b4e5cf3b8711b6
Submitter: Zuul
Branch: stable/pike

commit 0e57f89b8b0e3ed39c7fe59ee9b4e5cf3b8711b6
Author: Mohammed Naser <email address hidden>
Date: Fri Jan 19 11:45:41 2018 -0800

    Move disk space check to run when needed

    At the moment, the check for disk space when booting from an image
    currently happens regardless if the backend supports cloning or not.

    This means that even if a backend can clone the image directly, the
    control plane must have enough disk to download the entire image
    which can be unreasonable in backend such as RBD.

    This patch moves the code which checks for enough disk space to be
    in the same function that effectively downloads the image, ensuring
    that it only runs when an image has to be downloaded and avoiding
    the check if the backend successfully cloned the image.

    Closes-Bug: #1744383
    Change-Id: Ibfd6f40e8b8ab88d4ec76e9ac27617a0f97b6c29
    (cherry picked from commit f62f8abad17d1c287d48ea273ea4c4fe7f536d07)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 12.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 11.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/571709

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/571709
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=e82b8393b2a8ea1b3494131443dc9821f22a7e3d
Submitter: Zuul
Branch: stable/ocata

commit e82b8393b2a8ea1b3494131443dc9821f22a7e3d
Author: Mohammed Naser <email address hidden>
Date: Fri Jan 19 11:45:41 2018 -0800

    Move disk space check to run when needed

    At the moment, the check for disk space when booting from an image
    currently happens regardless if the backend supports cloning or not.

    This means that even if a backend can clone the image directly, the
    control plane must have enough disk to download the entire image
    which can be unreasonable in backend such as RBD.

    This patch moves the code which checks for enough disk space to be
    in the same function that effectively downloads the image, ensuring
    that it only runs when an image has to be downloaded and avoiding
    the check if the backend successfully cloned the image.

    Closes-Bug: #1744383
    Change-Id: Ibfd6f40e8b8ab88d4ec76e9ac27617a0f97b6c29
    (cherry picked from commit f62f8abad17d1c287d48ea273ea4c4fe7f536d07)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/cinder 10.0.8 release.