Underscores not allowed when creating new key pair

[Ola Khalifa]

When creating a new key pair horizon doesn't allow underscores in key pair name. However, according to the nova api this is allowed.

Nova api: https://github.com/openstack/nova/blob/master/nova/compute/api.py#L3690

[Akihiro Motoki (amotoki)]

The link of nova/compute/api.py is out-of-date.
I think the bug reporter would like to mention https://github.com/openstack/nova/blob/67808db2a136de3685421a2cc857c1ebfe86b220/nova/compute/api.py#L5207-L5212

[Marek Lyčka (mareklycka)]

Hi,

is this currently being worked on or can I take it over?

Thanks.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/598079

[Marek Lyčka (mareklycka)]

Since no one seemed interested, I took over the task.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/598079
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f269ab3b22eb2500d8d93d613c631b08865b4cc1
Submitter: Zuul
Branch: master

commit f269ab3b22eb2500d8d93d613c631b08865b4cc1
Author: Marek <email address hidden>
Date: Thu Aug 30 10:03:47 2018 +0200

    Fixes input validation in angular kepyairs.

    Modifies the regexp used by the angular form validation
    to match the allowed characters in Nova API as well
    as the description thereof.

    Change-Id: I5bb1c1cc531565416efbce16994306cb9ad79000
    Closes-bug: #1743887

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 15.0.0.0b1 development milestone.