container tag discover needs to support multiple labels to build tag

Bug #1743883 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Steve Baker

Bug Description

Some downstream build pipelines do not apply a label which exactly matches the version tag. The only way to build the full versioned tag is by combining multiple labels in a template pattern.

If --tag-from-label could take a template pattern which contains multiple labels, these build pipelines can be accommodated.

Tags: containers
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Steve Baker (steve-stevebaker)
milestone: none → queens-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/537732

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/537733

tags: added: containers
Changed in tripleo:
milestone: queens-3 → queens-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (master)

Reviewed: https://review.openstack.org/537732
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=7fb175465bcfeb2021d2e844c308c82f59567712
Submitter: Zuul
Branch: master

commit 7fb175465bcfeb2021d2e844c308c82f59567712
Author: Steve Baker <email address hidden>
Date: Thu Jan 25 16:35:00 2018 +1300

    Allow a combination of labels for tag discover

    Some downstream build pipelines do not apply a label which exactly
    matches the version tag. The only way to build the full versioned tag
    is by combining multiple labels in a template pattern.

    This change uses a python string.format syntax to allow multiple tags
    to be combined.

    Change-Id: Id0fb010ebcdd4d3f3650c94065fc42489475c42c
    Closes-Bug: #1743883

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on python-tripleoclient (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/537733
Reason: Reseting the gate to release milestone 3, I'll re-approve this patch asap.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/537733
Reason: Gate resets is causing issue to land a critical patch (538346) - I need to clear the gate until 538346 is merged. Please do not restore this patch, I'll take care of it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/537733
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=679a1f1681199403c58c5d4ba16d4a50f78f35ff
Submitter: Zuul
Branch: master

commit 679a1f1681199403c58c5d4ba16d4a50f78f35ff
Author: Steve Baker <email address hidden>
Date: Wed Jan 24 13:22:53 2018 +1300

    Document template enabled --tag-from-label

    This documents the new behaviour of allowing multiple labels to be
    used to determine the tag.

    Depends-On: Id0fb010ebcdd4d3f3650c94065fc42489475c42c
    Change-Id: I26b1dd644b46adc7ebaad6c29a50863f1fbced79
    Related-Bug: #1743883

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

I'm reopening this because there is a fix required for the tags to be actually substituted in the resulting file.

Changed in tripleo:
status: Fix Released → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (master)

Fix proposed to branch: master
Review: https://review.openstack.org/543761

Revision history for this message
Steve Baker (steve-stevebaker) wrote :

whoops wrong bug

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 8.5.0

This issue was fixed in the openstack/tripleo-common 8.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.