[R4.1-84]- SLO: matching sessions are getting logged 2 times of the expected rate

[alok kumar]

If SLO rate is configured 10 and 10 sessions are getting matched then 2 sessions are getting logged however it should log only once.

In current case, SLO rate is 10 and 10 ping pkts were sent between same endpoints.
for this 2 sessions were logged.

same result is seen for inter node and intra node traffic.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40124
Submitter: Madhusudan Bhat (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40124
Committed: http://github.com/Juniper/contrail-controller/commit/9794c2430f0bb67653ef01fa0c51d1456183b28d
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 9794c2430f0bb67653ef01fa0c51d1456183b28d
Author: bmadhu <email address hidden>
Date: Tue Feb 27 11:49:05 2018 +0530

Tear down logging
Teardown sessions are required to log with out checking the rate.
Earlier for tear down case also, SLO rate was checked, so it was not logged all the times.
This fix ensures tear down is always logged ignoring the rate.

Logging was twice the config SLO rate
Both forward and reverse flow was incrementing the rate, hence logging
was happening twice the configured rate. This fix ensures rate is checked and counter is
incremented only for either forward or reverse flow.

Logging the first session matching SLO and subsequent sessions matching rate
Earlier, session was logged after the matching configured SLO rate, this fix ensure
logging as per SLO spec, the first session matching the SLO and subsequent session matching the
rate. However there can be situation of SLO logs with bytes/pkts zero one time.

Change-Id: Ia68bfece05dc2f6aa85b78f7231cbf5b8e3ed81d
Closes-Bug: 1744690
Closes-Bug: 1743737

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/40528
Submitter: Madhusudan Bhat (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/40528
Committed: http://github.com/Juniper/contrail-controller/commit/7093af841e74fcdf482a7a605da9ad4d55a86bf5
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 7093af841e74fcdf482a7a605da9ad4d55a86bf5
Author: bmadhu <email address hidden>
Date: Tue Feb 27 11:49:05 2018 +0530

Tear down logging
Teardown sessions are required to log with out checking the rate.
Earlier for tear down case also, SLO rate was checked, so it was not logged all the times.
This fix ensures tear down is always logged ignoring the rate.

Logging was twice the config SLO rate
Both forward and reverse flow was incrementing the rate, hence logging
was happening twice the configured rate. This fix ensures rate is checked and counter is
incremented only for either forward or reverse flow.

Logging the first session matching SLO and subsequent sessions matching rate
Earlier, session was logged after the matching configured SLO rate, this fix ensure
logging as per SLO spec, the first session matching the SLO and subsequent session matching the
rate. However there can be situation of SLO logs with bytes/pkts zero one time.

Change-Id: Ia68bfece05dc2f6aa85b78f7231cbf5b8e3ed81d
Closes-Bug: 1744690
Closes-Bug: 1743737
(cherry picked from commit 9794c2430f0bb67653ef01fa0c51d1456183b28d)