Web Client: each item scanned into Check In reloads the whole page/list

Bug #1743045 reported by Christine Burns
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
3.0
Fix Released
Medium
Unassigned

Bug Description

Tested on EG3

During Check In, each item scanned into Check In reloads the whole page/list.

Description
scan first barcode -> check in sound is made -> item is checked in and appears in the list
scan second barcode -> list temporarily disappears, screen flashes, check in sound is made, list reappears

each barcode scanned in check in causes the list to reload.

This is slowing down operations at the check in desk.

Desired behaviour
when an item barcode is scanned into check in - the list of items previously checked in items should not refresh

Revision history for this message
Anna Goben (agoben) wrote :

One of my libraries reported that they are having to reload the interface fresh after approximately every 15 items or it is simply too slow to use.

Remington Steed (rjs7)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Remington Steed (rjs7) wrote :

I actually see the grid refresh twice:

- The first time, to display a blank row, where the new item will be displayed once it is fetched
- A second time, to populate the blank row with fetched data

I would be simple to remove the first refresh (which should cut the delay in half), but there might be a good reason to keep it as is.

Revision history for this message
Bill Erickson (berick) wrote :

If I recall correctly, the stub entry is added to the grid so the checkins will appear in the order they are scanned, and not the order the API response returns. The order could be maintained through other means, though.

Revision history for this message
Jeff Davis (jdavis-sitka) wrote :

Here's a branch that removes the first grid refresh during checkin, as Remington suggested:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1743045-checkin-refresh

It looks to me like this preserves the order of checkins in the grid.

tags: added: pullrequest
Remington Steed (rjs7)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Remington Steed (rjs7) wrote :

Tested on a slow server by checking in items quickly in a row, and it appears the item position is correctly tracked in the data array without the refresh.

Here's my sign-off branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1743045-checkin-refresh

tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Confirmed redundant refresh on checkin is no more. Thanks Jeff and Remington! Merged to master and rel_3_0.

Changed in evergreen:
milestone: none → 3.1-rc
no longer affects: evergreen/3.1
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
Revision history for this message
Christine Burns (christine-burns) wrote :

Hello

While this fix has made a slight improvement to check-in this has not completely fixed the issue.

Each check in still rebuilds the list and causes the screen to flash - this slows down check in and causes issues for the check in staff member (flashing screen)

I have attached a very short video which captures this list rebuilding issue

Revision history for this message
Josh Stompro (u-launchpad-stompro-org) wrote :

See bug 1777207 for more work related to this issue.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.