paunch should run for all steps, even when no services are enabled

[Steven Hardy]

There is currently a corner case where if you deploy with some services enabled in a particular step, then later update the deployment removing services, such that one or more steps no longer contain any services, we don't update the json files, or run paunch, which means the now-removed services are still running after update.

Instead, we should always write the json files for all steps, and therefore run paunch, for every step, but ensure the files are correctly updated to be empty (e.g an empty map) when no services exist for that step.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/533185

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/533185
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=41988eab39b742481d9ea994c4600ba49110f585
Submitter: Zuul
Branch: master

commit 41988eab39b742481d9ea994c4600ba49110f585
Author: Steven Hardy <email address hidden>
Date: Fri Jan 12 13:17:08 2018 +0000

    Default empty map for docker_config steps

    In the event a step has no services defined, we must still write the
    config, as this is needed if services are disabled on update such that
    a step becomes empty - we must run paunch on every step or the cleanup
    of the "old" services does not happen.

    Closes-Bug: 1742915
    Change-Id: Iee01002f56b5311560557f2bf6f053601b9d43d7

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0b3 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/561964
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2e224ddaaac2f37084c6c46b7157f2aa26b1d711
Submitter: Zuul
Branch: master

commit 2e224ddaaac2f37084c6c46b7157f2aa26b1d711
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Apr 17 16:39:43 2018 +0200

    Add missing hiera interpolation calls

    Complements [0], [1]

    [0] https://review.openstack.org/#/c/526692
    [1] https://review.openstack.org/#/c/561498

    Related-bug: #1742915

    Change-Id: I57859178988e92f926b6c41370afd8b0d1552831
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/queens
Review: https://review.opendev.org/692228

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692228
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a94f761c20da662b0a64ba0c7b833f6b6dc1ef55
Submitter: Zuul
Branch: stable/queens

commit a94f761c20da662b0a64ba0c7b833f6b6dc1ef55
Author: Bogdan Dobrelya <email address hidden>
Date: Tue Apr 17 16:39:43 2018 +0200

    Add missing hiera interpolation calls

    Complements [0], [1]

    [0] https://review.openstack.org/#/c/526692
    [1] https://review.openstack.org/#/c/561498

    Related-bug: #1742915

    Conflicts:
     docker/services/novajoin.yaml

    Change-Id: I57859178988e92f926b6c41370afd8b0d1552831
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 2e224ddaaac2f37084c6c46b7157f2aa26b1d711)