Remove multiconfig parser from UCSM ML2 driver

Bug #1742911 reported by Sam Betts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-cisco
In Progress
High
Sam Betts

Bug Description

The multiconfig parser from oslo.config is deprecation and will be removed in a future release of oslo.config, so we need to switch to using native oslo.config method for parsing the UCSM ml2 configuration.

Changed in networking-cisco:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/531213
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=ec5244fd24694c7c0daf7da9b26708b52944a6c9
Submitter: Zuul
Branch: master

commit ec5244fd24694c7c0daf7da9b26708b52944a6c9
Author: Sam Betts <email address hidden>
Date: Thu Jan 4 18:53:02 2018 +0000

    Remove Multiconfig parser from UCSM ML2 driver

    This is the first patch in the process for switching the UCSM ML2 driver
    over to using standard oslo.config for all its configuration options.

    Change-Id: I776f470ef1aacedeb7ae38d45286278c5dc88244
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/531841
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=165d55ff2ea45dee700d87176bdb0f164ae513fa
Submitter: Zuul
Branch: master

commit 165d55ff2ea45dee700d87176bdb0f164ae513fa
Author: Sam Betts <email address hidden>
Date: Mon Jan 8 13:01:45 2018 +0000

    Load single UCSM config like multi UCSM config

    This patch standardises how single and multi UCSM configs are loaded, so
    that the code can treat both cases transparently.

    Change-Id: I17df6581c6610195d65902264f75d13f08df681c
    Related-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531842
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=44da50594d3a5b5709bacaed2f0ec3ccb40e104c
Submitter: Zuul
Branch: master

commit 44da50594d3a5b5709bacaed2f0ec3ccb40e104c
Author: Sam Betts <email address hidden>
Date: Mon Jan 8 14:25:42 2018 +0000

    Remove get_credentials_for_ucsm_ip config helper function

    Use cfg.CONF directly instead.

    Change-Id: Idedf8008c4a0caed5e98f25b19b8c3f48415a99b
    Related-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531843
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=6be85498dcf5c89d66e3e2370677a9a3681ef311
Submitter: Zuul
Branch: master

commit 6be85498dcf5c89d66e3e2370677a9a3681ef311
Author: Sam Betts <email address hidden>
Date: Mon Jan 8 14:37:44 2018 +0000

    Remove multi_ucsm_mode and get_all_ucsm_ips functions

    This patch removes two more helper functions that aren't really needed
    now we can use oslo config directly.

    Change-Id: Id20739ddc35ac9c204769e21326c8d2d47602dda
    Related-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/531932
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=68b31f13b6094567cc81af8b30d043d81254f4bd
Submitter: Zuul
Branch: master

commit 68b31f13b6094567cc81af8b30d043d81254f4bd
Author: Sam Betts <email address hidden>
Date: Mon Jan 8 16:36:08 2018 +0000

    Use ucsm PCI devices directly from oslo.config

    Change-Id: I0e6a5a529d15ab61e4a3a56fb542c7fb35c6aca2
    Related-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-cisco (master)

Reviewed: https://review.openstack.org/531845
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=c5a02c3edb3049b77a50fc5e80f371eb7c631887
Submitter: Zuul
Branch: master

commit c5a02c3edb3049b77a50fc5e80f371eb7c631887
Author: Sam Betts <email address hidden>
Date: Mon Jan 8 16:21:32 2018 +0000

    Use oslo.config to process the SP template list

    This patch adds a new oslo.config type to process the SP template list
    configuration data. This passes the configuration processing off to
    oslo.config instead of having to handle it in a help method every time.
    Now the data is correctly formatted in oslo.config we can remove several
    helper methods that were designed to aid retreiving the data in the
    correct format.

    Change-Id: I0e5576e3788a0ed27af9104e1f9078ba01047c6f
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532292
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=4a4d401abc4681834d16d833b145cdd94ca7f24c
Submitter: Zuul
Branch: master

commit 4a4d401abc4681834d16d833b145cdd94ca7f24c
Author: Sam Betts <email address hidden>
Date: Tue Jan 9 12:39:47 2018 +0000

    Add a more complete testcase for the UCSM configuration

    The unit tests are written to suit the new way the config is being
    handled using oslo config. The old unit tests suit the way the config
    was being handled (with local dicts being created to hold parsed
    config.) Now, the configuration is consolidated within oslo config
    variables are so the tests compare expected data against how these oslo
    config variables instead.

    Change-Id: Ibcce36ca32186f8e9418f6218cbcd48d63c9f146
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532293
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=006e43b6d1bdc7b04f8d2928f8ff07e481eaf8ae
Submitter: Zuul
Branch: master

commit 006e43b6d1bdc7b04f8d2928f8ff07e481eaf8ae
Author: Sam Betts <email address hidden>
Date: Tue Jan 9 17:29:18 2018 +0000

    Use UCSM VNIC templates directly from oslo.config

    This patch changes the oslo.config option type for the UCSM VNIC
    templates so that they can be accessed directly from oslo.config without
    further processing.

    Change-Id: Ibc5c40ed35fc77540ec984d49db41ded0c8d6f6c
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532294
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=cef653e276cfade4b33e602f90cc876fb2255b52
Submitter: Zuul
Branch: master

commit cef653e276cfade4b33e602f90cc876fb2255b52
Author: Sam Betts <email address hidden>
Date: Tue Jan 9 18:02:23 2018 +0000

    Get sriov_qos_policy directly from oslo.config

    This patch allows us to fetch sriov_qos_policy directly from
    oslo.config, removing the requirement on the helper function which
    picked the option from the global or specific UCSM configs.

    Change-Id: I7e981ec637ce595568896c1821f20f55e61567eb
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532295
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=aab67dd41672c7231796293bf9020c0be489f6ea
Submitter: Zuul
Branch: master

commit aab67dd41672c7231796293bf9020c0be489f6ea
Author: Sam Betts <email address hidden>
Date: Tue Jan 9 19:17:36 2018 +0000

    Load SRIOV multivlan configuration directly with oslo.config

    This patch adds a new item type to the RemainderOpt oslo.config option
    which allows it to process vlan ranges in "1-5" into a list of vlans
    [1,2,3,4,5], this means we can use the oslo.config option directly
    without the need to have a helper function handle the processing for us.

    Change-Id: Ic66669085692a01dbccbe8349c20b16b7c32d157
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532600
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=cbe561335baf4f41542c33690eae6c49dd06acb8
Submitter: Zuul
Branch: master

commit cbe561335baf4f41542c33690eae6c49dd06acb8
Author: Sam Betts <email address hidden>
Date: Wed Jan 10 16:32:20 2018 +0000

    Remove is_vnic_template_configured configuration helper method

    This patch removes the need for the is_vnic_template_configured helper
    method by using oslo.config directly.

    Change-Id: Id3ce77c4c76733e332f00a9371c902fe7f22e5af
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532601
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=60d347e561cb5985ff1aa6b297fa795b88376680
Submitter: Zuul
Branch: master

commit 60d347e561cb5985ff1aa6b297fa795b88376680
Author: Sam Betts <email address hidden>
Date: Wed Jan 10 18:13:54 2018 +0000

    Remove ucsm_sp_dict and ucsm_host_dict from ucsm config module

    This patch removes the need to load the ucsm_sp_dict and ucsm_host_dict
    in the ucsm config module, and instead uses oslo.config directly in the
    UCSM network driver.

    Change-Id: I6ee298883b900692faa60fe05e9efdace152b792
    Partial-Bug: #1742911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/532602
Committed: https://git.openstack.org/cgit/openstack/networking-cisco/commit/?id=db86e67747e9ef933ffa738f89c17deb01b9b737
Submitter: Zuul
Branch: master

commit db86e67747e9ef933ffa738f89c17deb01b9b737
Author: Sam Betts <email address hidden>
Date: Wed Jan 10 18:38:50 2018 +0000

    Remove the UcsmConfig class from the ucsm ml2 driver config

    Now there is no configuration stored outside of the oslo.config
    configuration, we can remove the class that was required to store this
    data globally in the ucsm config module.

    Change-Id: I80ac585341260ad120c391ed896975835f1d289c
    Partial-Bug: #1742911

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.