Unable to set root_device via instackenv.json

[Dmitry Tantsur]

Setting the root_device property is critically important for nodes with multiple disks. While both ironic and tripleo CLI provide support for it, it cannot be set via instackenv.json.

Initially reported as https://bugzilla.redhat.com/show_bug.cgi?id=1533665

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/533145

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/533145
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=896d20797f2b90c749f3868e735c6865e19998d6
Submitter: Zuul
Branch: master

commit 896d20797f2b90c749f3868e735c6865e19998d6
Author: Dmitry Tantsur <email address hidden>
Date: Fri Jan 12 11:27:34 2018 +0100

    Add missing support for the root_device property

    Our documentation requires it to be set for multi-disk nodes, but it's
    not accepted in instackenv.json. This patch fixes it.

    As a side fix, property values are no longer converted to strings. This
    has never been required, and may potentially yield incorrect results
    (like with root_device, which is a dictionary).

    Change-Id: I4e9fbc940c424071206e96b3d90086282f381a9f
    Closes-Bug: #1742905

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 8.4.0 release.