Need to review security resources before enforce them

Bug #1742774 reported by Édouard Thuleau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
Trunk
Fix Committed
High
Édouard Thuleau

Bug Description

We need to be able to review security modifications before applying them

Tags: config
Jeba Paulaiyan (jebap)
tags: added: config
information type: Proprietary → Public
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/38936
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39114
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39114
Committed: http://github.com/Juniper/contrail-specs/commit/c5162b9c5a67d7887a977fa1da103d90a9e3b9ac
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit c5162b9c5a67d7887a977fa1da103d90a9e3b9ac
Author: Édouard Thuleau <email address hidden>
Date: Mon Jan 22 18:42:32 2018 +0100

Update specs of security draft mode blueprint

Some fixes found when we wrote Contrail schema data model changes.

Change-Id: Id1d9e788608079c03773136ffc2206a824d28472
Partially-Implements: blueprint security-draft-mode
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38936
Committed: http://github.com/Juniper/contrail-controller/commit/d1b91c75162f533079f727c826d4c467c3174a1a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit d1b91c75162f533079f727c826d4c467c3174a1a
Author: Édouard Thuleau <email address hidden>
Date: Tue Jan 16 19:29:52 2018 +0100

Schema changes for the security draft mode blueprint

Depends-on: Ibac92786d31f5702ccf0e35eb1720efacda4c316
Change-Id: I623659516ab4ee004bcbe307483ff2376afed0df
Partially-Implements: blueprint security-draft-mode
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39288
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39288
Submitter: Siva Bavanasi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39288
Committed: http://github.com/Juniper/contrail-specs/commit/bac8e7670978ab0a79572ed545ea2d784ee173a6
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit bac8e7670978ab0a79572ed545ea2d784ee173a6
Author: Siva Kumar Bavanasi <email address hidden>
Date: Mon Jan 29 15:55:30 2018 +0530

UI Changes for security draft mode blueprint

Change-Id: I8f562ac5373de41c7d573a375f7d5b4ab8e619ff
Partial-bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39788
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/39788
Committed: http://github.com/Juniper/contrail-specs/commit/cf2a684a352c3b438aaef1825d4746c8e174f8c8
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit cf2a684a352c3b438aaef1825d4746c8e174f8c8
Author: Édouard Thuleau <email address hidden>
Date: Thu Feb 15 13:09:11 2018 +0100

Fix errors in the Security Draft Mode spec

Change-Id: I55095c64450de9541307d2538324d47300dbbcd7
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40567
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40579
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40579
Committed: http://github.com/Juniper/contrail-specs/commit/1acc1a5374c153907d7e966ad6ccf795c8064f7a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 1acc1a5374c153907d7e966ad6ccf795c8064f7a
Author: Édouard Thuleau <email address hidden>
Date: Tue Mar 13 09:58:01 2018 +0100

Fix Security Draft Mode spec

It was decided to not change the Contrail REST API read method. So the
'draft' flag to obtain draft version of a security resource if it exists
was removed.

Change-Id: I93c42aa33f69853dc7ce6509245c671a72d9de26
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/39255
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40567
Committed: http://github.com/Juniper/contrail-api-client/commit/82bd8e77de1671f4372921758cc6aaa25bb8476c
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 82bd8e77de1671f4372921758cc6aaa25bb8476c
Author: Édouard Thuleau <email address hidden>
Date: Mon Mar 12 23:59:36 2018 +0100

Schema fix for security draft mode

For the security draft mode, new property was added to mark a security
as deleted. As that property is system only, that patch limit CRUD to
read only.

Change-Id: I618df58a6f0a9f8cd02e68a4241b3d3a045ba286
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/39255
Committed: http://github.com/Juniper/contrail-controller/commit/c5699a52112354b9c9efd040b3b59cd3924fa560
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit c5699a52112354b9c9efd040b3b59cd3924fa560
Author: Édouard Thuleau <email address hidden>
Date: Fri Jan 26 18:19:42 2018 +0100

[config] Security draft mode

Adds the config code to support Security draft mode [1].

[1] https://github.com/Juniper/contrail-specs/blob/master/security_draft_mode.md
[2] https://blueprints.launchpad.net/juniperopenstack/+spec/security-draft-mode

Partially-Implements: blueprint security-draft-mode [2]
Partial-Bug: #1742774
Depends-on: I618df58a6f0a9f8cd02e68a4241b3d3a045ba286
Change-Id: Iceb46ac2babb6f5d319f5b9bcc5c2050684de39c

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40866
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40867
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40866
Committed: http://github.com/Juniper/contrail-specs/commit/763ffeb25b9991bf72333f31efc21955b26b454a
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit 763ffeb25b9991bf72333f31efc21955b26b454a
Author: Édouard Thuleau <email address hidden>
Date: Tue Mar 20 18:13:52 2018 +0100

Update security draft mode spec

Replace the boolean property 'pending_update' of a security resource
by an enum property to specified if it's a draft resource creation,
modification or deletion. If not set that means it's not a draft
security resource.

Change-Id: I6fb4075b14c52f38115a0a980d1edb3cf94683e5
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40913
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40867
Committed: http://github.com/Juniper/contrail-api-client/commit/f7b0caadc79264bdda226f2b1710aab4ce51fcc4
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit f7b0caadc79264bdda226f2b1710aab4ce51fcc4
Author: Édouard Thuleau <email address hidden>
Date: Tue Mar 20 17:29:27 2018 +0100

Update security draft mode model

Replace the boolean property 'pending_update' of a security resource
by an enum property to specified if it's a draft resource creation,
modification or deletion. If not set that means it's not a draft
security resource.

Change-Id: I8050c97f23cc74600ee659614d9f02a0e9a17561
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/41003
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Review in progress for https://review.opencontrail.org/40913
Submitter: Édouard Thuleau (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/41003
Committed: http://github.com/Juniper/contrail-api-client/commit/34c27ffb347b6b47f3f9284a7230ed79ed39d961
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit 34c27ffb347b6b47f3f9284a7230ed79ed39d961
Author: Édouard Thuleau <email address hidden>
Date: Tue Mar 20 17:29:27 2018 +0100

Update security draft mode model

Replace the boolean property 'pending_update' of a security resource
by an enum property to specified if it's a draft resource creation,
modification or deletion. If not set that means it's not a draft
security resource.

Change-Id: If8db3564932c2446328091f42932c068f5e9cc40
Partial-Bug: #1742774

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40913
Committed: http://github.com/Juniper/contrail-controller/commit/15a9721f2e5f0d1b054e807fce5cd58a3d7922c6
Submitter: Rudra Rugge (<email address hidden>)
Branch: master

commit 15a9721f2e5f0d1b054e807fce5cd58a3d7922c6
Author: Édouard Thuleau <email address hidden>
Date: Wed Mar 21 18:02:36 2018 +0100

[config] Change security draft mode model

Replace the boolean property 'pending_update' of a security resource by an enum
property to specified if it's a draft resource creation, modification or
deletion. If not set that means it's not a draft security resource.
Also don't unset draft mode on the scope after a commit and a revert
action on it.

Change-Id: I2c7dc31e99e3b4a690870b065f9969dff73cedff
Partial-Bug: #1742774
Depends-On: If8db3564932c2446328091f42932c068f5e9cc40

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.